Re: pkg/56488: Solaris 10 compile issues, stdbool.h requires c99

[Claes Nästén <pekdon%gmail.com@localhost>]

The following reply was made to PR pkg/56488; it has been noted by GNATS.

From: =?utf-8?q?Claes_N=C3=A4st=C3=A9n?= <pekdon%gmail.com@localhost>
To: gnats-bugs <gnats-bugs%netbsd.org@localhost>
Cc: 
Subject: Re: pkg/56488: Solaris 10 compile issues, stdbool.h requires c99
Date: Thu, 11 Nov 2021 10:53:13 +0100

 Excerpts from nia's message of 2021-11-10 23:05:01 +0000:
 > The following reply was made to PR pkg/56488; it has been noted by GNATS.
 > 
 > From: nia <nia%NetBSD.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: 
 > Subject: Re: pkg/56488: Solaris 10 compile issues, stdbool.h requires c99
 > Date: Wed, 10 Nov 2021 23:03:06 +0000
 > 
 >  On Tue, Nov 09, 2021 at 12:00:02PM +0000, Claes Nstn wrote:
 >  >  Using flex as an example, it seems to include stdbool.h in
 >  >  src/flexdef.h unconditionally even though it checks for stdbool.h in
 >  >  configure and continues without it, it seems.
 >  >  
 >  >  I'm attaching the work.log and config.log, as I'm unsure what else you
 >  >  need.
 >  >  
 >  >  Will rebuild some of the other packages, hopefully providing some more
 >  >  insights to whether or not setting c99 is the way to go or not.
 >  
 >  Thanks, I found the reference to stdbool.h in devel/flex and
 >  applied the fix. However, I can't find the references to
 >  stdbool by grepping the other examples you gave.
 >  
 
 Sorry for being late to provide relevant information, but here comes
 some info on the p5-Socket6 package:
 
 ===> Configuring for p5-Socket6-0.29nb3
 checking for gcc... gcc
 checking whether the C compiler works... yes
 checking for C compiler default output file name... a.out
 checking for suffix of executables... 
 checking whether we are cross compiling... no
 checking for suffix of object files... o
 checking whether we are using the GNU C compiler... yes
 checking whether gcc accepts -g... yes
 checking for gcc option to accept ISO C89... none needed
 checking whether your Perl5 have PL_sv_undef... no
 checking how to run the C preprocessor... cpp
 checking for grep that handles long lines and -e... /usr/pkgsrc/net/p5-Socket6/work/.tools/bin/grep
 checking for egrep... /usr/pkgsrc/net/p5-Socket6/work/.tools/bin/grep -E
 checking for getaddrinfo... no
 checking for getaddrinfo in -lsocket... yes
 checking for getnameinfo... yes
 checking for gethostbyname2... no checking for gethostbyname2 in -lsocket... no
 checking whether your system has IPv6 directory... no
 checking for getipnodebyname... yes
 checking for getipnodebyaddr... yes
 checking for inet_pton... yes
 checking for inet_ntop... yes
 checking for working inet_ntop... yes
 checking whether you have sa_len in struct sockaddr... no
 checking whether you have sin6_scope_id in struct sockaddr_in6... yes
 checking for socklen_t... yes
 sort: cannot stat temporary directory : No such file or directory
 configure: creating ./config.status
 config.status: creating config.pl
 config.status: creating gailookup.pl
 config.status: creating config.h
 sort: cannot stat temporary directory : No such file or directory
 sort: cannot stat temporary directory : No such file or directory
 Checking if your kit is complete...
 Looks good
 Generating a Unix-style Makefile
 Writing Makefile for Socket6
 Writing MYMETA.yml and MYMETA.json
 ===> Building for p5-Socket6-0.29nb3
 cp Socket6.pm blib/lib/Socket6.pm
 Running Mkbootstrap for Socket6 ()
 chmod 644 "Socket6.bs"
 "/usr/pkg.new/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- Socket6.bs blib/arch/auto/Socket6/Socket6.bs 644
 "/usr/pkg.new/bin/perl" "/usr/pkg.new/lib/perl5/5.34.0/ExtUtils/xsubpp" -noprototypes -typemap '/usr/pkg.new/lib/perl5/5.34.0/ExtUtils/typemap'  Socket6.xs > Socket6.xsc
 mv Socket6.xsc Socket6.c
 gcc -c    -D_REENTRANT -O2 -D_FORTIFY_SOURCE=2 -pthread -I/usr/include -fno-strict-aliasing -pipe -mcpu=v9 -m64 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DPERL_USE_SAFE_PUTENV -O2 -D_FORTIFY_SOURCE=2 -I/usr/pkg.new/include -I/usr/include    -I/usr/pkg.new/include -I/usr/include    -DVERSION=\"0.29\"  -DXS_VERSION=\"0.29\" -fPIC "-I/usr/pkg.new/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE"   Socket6.c
 gcc: unrecognized option `-pthread'
 In file included from /usr/pkgsrc/net/p5-Socket6/work/.buildlink/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/handy.h:110,
                  from /usr/pkgsrc/net/p5-Socket6/work/.buildlink/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/perl.h:2930,
                  from Socket6.xs:81:
 /usr/include/stdbool.h:42:2: #error "Use of <stdbool.h> is valid only in a c99 compilation environment."
 In file included from Socket6.xs:81:
 /usr/pkgsrc/net/p5-Socket6/work/.buildlink/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/perl.h:3975: error: syntax error before "bool"
 /usr/pkgsrc/net/p5-Socket6/work/.buildlink/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/perl.h:3975: warning: no semicolon at end of struct or union
 /usr/pkgsrc/net/p5-Socket6/work/.buildlink/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/perl.h:3978: error: syntax error before '}' token
 In file included from /usr/pkgsrc/net/p5-Socket6/work/.buildlink/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/perl.h:4076,
                  from Socket6.xs:81:
 /usr/pkgsrc/net/p5-Socket6/work/.buildlink/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/sv.h:495: error: syntax error before "bool"
 /usr/pkgsrc/net/p5-Socket6/work/.buildlink/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/sv.h:495: warning: no semicolon at end of struct or union
 /usr/pkgsrc/net/p5-Socket6/work/.buildlink/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/sv.h:502: error: syntax error before "bool"
 /usr/pkgsrc/net/p5-Socket6/work/.buildlink/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/sv.h:502: warning: no semicolon at end of struct or union
 
 And a long list of errors follows.
 
 Looking at:
 
 /usr/pkg.new/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/config.h
 
 /* I_STDBOOL:
  *      This symbol, if defined, indicates that <stdbool.h> exists and
  *      can be included.
  */
 #define I_STDBOOL               /**/
 
 And then:
 
 /usr/pkg.new/lib/perl5/5.34.0/sparc64-solaris-thread-multi-64/CORE/handy.h
 
 #if defined(I_STDBOOL) && !defined(PERL_BOOL_AS_CHAR)
 #  include <stdbool.h>
 #  ifndef HAS_BOOL
 #    define HAS_BOOL 1
 #  endif
 #endif
 
 Suggests it would be used for a lot of perl packages don't you think?