pkg/56475: x11/xf86-video-xgi build fails on Linux with "open with O_CREAT or O_TMPFILE in second argument needs 3 arguments"

[cryintothebluesky%gmail.com@localhost]

>Number:         56475
>Category:       pkg
>Synopsis:       x11/xf86-video-xgi build fails on Linux with "open with O_CREAT or O_TMPFILE in second argument needs 3 arguments"
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 29 20:05:00 +0000 2021
>Originator:     Sad Clouds
>Release:        
>Organization:
>Environment:
Linux debian11 5.10.0-9-amd64 #1 SMP Debian 5.10.70-1 (2021-09-30) x86_64 GNU/Linux

>Description:
This package is pulled in as a dependency of building modular xorg and it fails with the following errors:

In file included from /usr/include/fcntl.h:301,
                 from xgi_driver.c:109:
In function 'open',
    inlined from 'XGIPreInit' at xgi_driver.c:2800:19:
/usr/include/x86_64-linux-gnu/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments
   50 |           __open_missing_mode ();
      |           ^~~~~~~~~~~~~~~~~~~~~~
*** [xgi_driver.lo] Error code 1



>How-To-Repeat:

>Fix:
--- /opt/pkg.objects/x11/xf86-video-xgi/work/xf86-video-xgi-1.6.1/src/xgi_driver.c.orig 2021-10-29 18:22:39.908804948 +0100
+++ /opt/pkg.objects/x11/xf86-video-xgi/work/xf86-video-xgi-1.6.1/src/xgi_driver.c      2021-10-29 18:23:55.080936632 +0100
@@ -2797,7 +2797,7 @@
     FbDevExist = FALSE;
    if((pXGI->Chipset != PCI_CHIP_XGIXG20)&&(pXGI->Chipset != PCI_CHIP_XGIXG21)&&( pXGI->Chipset != PCI_CHIP_XGIXG27 ))
    {
-        if ((fd = open("/dev/fb", 'r')) != -1) {
+        if ((fd = open("/dev/fb", O_RDONLY)) != -1) {
             PDEBUG(ErrorF("--- open /dev/fb....   \n"));
             ioctl(fd, FBIOGET_FSCREENINFO, &fix);
             if (fix.accel == FB_ACCEL_XGI_GLAMOUR) {