Re: pkg/56315: NetBSD/earmv7hf atomics don't work for net/bind916

[john%ziaspace.com@localhost]

The following reply was made to PR pkg/56315; it has been noted by GNATS.

From: john%ziaspace.com@localhost
To: gnats-bugs%netbsd.org@localhost
Cc: pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/56315: NetBSD/earmv7hf atomics don't work for net/bind916
Date: Sun, 18 Jul 2021 17:12:38 +0000 (UTC)

 > Does this patch improve the situation? (not tested)
 >
 > http://www.netbsd.org/~rin/patch-lib_isc_include_isc_types.h
 >
 > Background: isc__atomic_statcounter_t is modified for !_LP64
 > platforms by our local patch in pkgsrc, but isc_statscounter_t
 > is left untouched unfortunately.
 >
 > Our libc for ARMv6 and later has 64-bit atomic ops, but
 > I don't think it is worth to add one more hack to support it...
 
 Improves, in that it gets further, but doesn't fix:
 
 libtool: compile:  gcc -include 
 /usr/pkgsrc/net/bind916/work/bind-9.16.18/config.h 
 -I/usr/pkgsrc/net/bind916/work/bind-9.16.18 -I../.. -I. -I../../lib/ns 
 -Iinclude -I/usr/pkgsrc/net/bind916/work/bind-9.16.18/lib/ns/include 
 -I../../lib/ns/include 
 -I/usr/pkgsrc/net/bind916/work/bind-9.16.18/lib/dns/include 
 -I../../lib/dns/include 
 -I/usr/pkgsrc/net/bind916/work/bind-9.16.18/lib/isc/include 
 -I../../lib/isc -I../../lib/isc/include -I../../lib/isc/unix/include 
 -I../../lib/isc/pthreads/include 
 -DNAMED_PLUGINDIR=\"/usr/local/lib/named\" -O2 -D_FORTIFY_SOURCE=2 
 -pthread -I/usr/include/readline 
 -I/usr/pkgsrc/net/bind916/work/.buildlink/include -pthread -fPIC -W -Wall 
 -Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wformat -Wpointer-arith 
 -Wno-missing-field-initializers -fno-strict-aliasing -c client.c  -fPIC 
 -DPIC -o .libs/client.o
 client.c:133:42: error: conflicting types for 'ns_client_requests'
   LIBNS_EXTERNAL_DATA atomic_uint_fast64_t ns_client_requests =
                                            ^~~~~~~~~~~~~~~~~~
 In file included from client.c:57:0:
 include/ns/client.h:283:49: note: previous declaration of 
 'ns_client_requests' was here
   LIBNS_EXTERNAL_DATA extern atomic_uint_fast32_t ns_client_requests;
                                                   ^~~~~~~~~~~~~~~~~~
 *** Error code 1
 
 John