Re: pkg/55086: compiling net/tigervnc on Solaris

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/55086; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/55086: compiling net/tigervnc on Solaris
Date: Sat, 17 Jul 2021 08:25:48 +0000

 On Mon, Jul 12, 2021 at 06:10:01AM +0000, Clausen, J?rn wrote:
  >  randutil.c contains an unconditional implementation of
  >  
  >  void random_get_bytes(void *buf, size_t nbytes)
  >  
  >  that conflicts with Solaris'
  >  
  >  extern int random_get_bytes(uint8_t *dbuf, size_t dlen);
  >  
  >  as long as <sys/random.h> is included. When that header is commented 
  >  out, other definitions are missing and compilations fails as well. I 
  >  guess it would take some effort to make libuuid more portable...
 
 Is that random_get_bytes suitable for what the code wants? (That is,
 should I patch it so it uses the Solaris function, or to rename its
 own function to avoid the conflict?)
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost