Re: pkg/55306 (Pkgsrc bootstrap failure with gcc 10, pax fails to build with -fno-common (default in GCC>=10))

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/55306; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/55306 (Pkgsrc bootstrap failure with gcc 10, pax fails to
 build with -fno-common (default in GCC>=10))
Date: Sat, 17 Jul 2021 08:07:09 +0000

 On Thu, Jul 15, 2021 at 07:15:02AM +0000, Frederic Fauberteau wrote:
  >  $ uname -mrs
  >  Linux 5.12.15-arch1-1 x86_64
  >  $ cc --version
  >  cc (GCC) 11.1.0
  >  
  >  I get the very same error.
 
 The following patch fixes it, but it's not clear how to proceed. It
 looks like archivers/pax was last updated from base in about 2008, and
 while it should be updated that's going to be a big job and probably
 break a bunch of bootstraps. But until that's done, changing files/
 is undesirable. But on the third hand, I don't think it's safe to add
 patches to bootstrap packages either, and that's the only other
 reasonable alternative.
 
 
 --- extern.h~	2021-07-17 07:36:58.710288341 +0000
 +++ extern.h
 @@ -214,10 +214,10 @@ OPLIST * opt_next(void);
  int opt_add(const char *);
  int bad_opt(void);
  int mkpath(char *);
 -char *chdname;
 +extern char *chdname;
  #if !HAVE_NBTOOL_CONFIG_H
  #ifdef HAVE_FCHROOT
 -int do_chroot;
 +extern int do_chroot;
  #endif /* HAVE_FCHROOT */
  #endif
  
 --- options.c~	2021-07-17 07:36:58.720604534 +0000
 +++ options.c
 @@ -107,6 +107,13 @@ __RCSID("$NetBSD: options.c,v 1.11 2010/
  #include "mtree.h"
  #endif	/* SMALL */
  
 +char *chdname;
 +#if !HAVE_NBTOOL_CONFIG_H
 +#ifdef HAVE_FCHROOT
 +int do_chroot;
 +#endif
 +#endif
 +
  /*
   * Routines which handle command line options
   */
 
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost