Re: pkg/56299 (Native X11_TYPE on NetBSD even if /usr/X11R7 does not exist)

[Frederic Fauberteau <triaxx%NetBSD.org@localhost>]

The following reply was made to PR pkg/56299; it has been noted by GNATS.

From: Frederic Fauberteau <triaxx%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/56299 (Native X11_TYPE on NetBSD even if /usr/X11R7 does not
 exist)
Date: Thu, 8 Jul 2021 23:06:56 +0200

 I don't remember how I installed them (from installer or by manually extracting sets), but I have NetBSD 9.0 machines with neither /etc/mtree/set.xbase nor /usr/X11R7. Even without a misconfigured sandbox, it seems to me that it is possible to build a pkgsrc bulk using the native X11 distribution while this distribution has actually not been installed.
 
 Would it make sense a patch as the following? The objective is to avoid getting a lot of packages for which the build fails due to this inconsistency.
 
 --- mk/platform/NetBSD.mk       25 Apr 2021 07:51:25 -0000      1.65
 +++ mk/platform/NetBSD.mk       8 Jul 2021 20:50:14 -0000
 @@ -45,6 +45,9 @@
  # to modular.
  .if empty(MACHINE_PLATFORM:MNetBSD-[0-5].*)
  X11_TYPE?=             native
 +.  if !empty(X11_TYPE:Mnative) && !exists(/etc/mtree/set.xbase)
 +PKG_FAIL_REASON+=      "Native X11 distribution cannot be used if xbase set has not been installed. You should set X11_TYPE=modular or install xbase set."
 +.  endif
  .endif
  
  _OPSYS_EMULDIR.aout=           /emul/aout