Re: toolchain/55879: make(1): error out on .else with extraneous text conflicts mk/readline.builtin.mk

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR pkg/55879; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: toolchain/55879: make(1): error out on .else with extraneous
 text conflicts mk/readline.builtin.mk
Date: Wed, 9 Jun 2021 00:39:12 +0000

 On Thu, Dec 17, 2020 at 08:20:00AM +0000, davshao%gmail.com@localhost wrote:
  > pkgsrc/mk/readline.builtin.mk
  > has around line 48
  > 
  > .    else if !empty(_READLINE_TYPE:Mreadline)
 
 This was fixed by ryoon about an hour and a half after you submitted
 the PR (and apparently nobody linked the two)
 
  > it seems from pkgsrc itself that the
  > 
  > .else conditional
  > 
  > construct is not regarded as an error in practice.  NetBSD's make
  > seems to be rapidly updated in other BSDs which may shortly result
  > in surprises for them.  Therefore perhaps this change should be reverted?
 
 It's supposed to be .elif conditional (as per the documentation) and
 it's quite likely that it just didn't work properly before, so if
 there are other wrong uses floating around it's probably best to trap
 and fix them as soon as possible.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost