Re: pkg/56186: libarchive: fix dirfd() check

["Lehel Bernadt (lbernadt)" <Lehel.Bernadt%oneidentity.com@localhost>]

On Fri, May 21, 2021 at 06:45:01AM +0000, nia wrote:
>
> You don't need to add anything to mk.conf, we can add it to the
> pkgsrc Makefile.
>
> autotools allows overriding the result of configure tests, that's
> one of its advantages.
>
> In pkgsrc, we can also add OS-specific overrides, e.g.
>
> CONFIGURE_ENV.SunOS+=   ac_cv_func_epoll_create=no
> CONFIGURE_ENV.SunOS+=   ac_cv_func_epoll_ctl=no
> CONFIGURE_ENV.SunOS+=   ac_cv_func_epoll_wait=no
>
> This sets a specific variable in the generated ./configure script
> so its result will be "cached" (already set).
>
> This _should_ be fixed in pkgsrc, IMO, libarchive is an essential
> library. My reply did not mean "fix it locally yourself", but rather
> that it should be fixed in pkgsrc in a different way.

I have some workarounds like this in my mk.conf:

.if ${PKGPATH} == converters/libiconv
CFLAGS+=                -fgnu89-inline
.endif

that's why my first thought was to add the configure override here for myself 
(I didn't know about the OS-specific part).

But having it in the pkgsrc Makefile is completely fine by me of course.

I will report the issue upstream as well though to have it permanently fixed.

Regards,
Lehel