pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/56092 (libreoffice hard-codes a /usr/bin/xdg-open ref)

The following reply was made to PR pkg/56092; it has been noted by GNATS.

From: "David H. Gutteridge" <>
Subject: Re: pkg/56092 (libreoffice hard-codes a /usr/bin/xdg-open ref)
Date: Tue, 06 Apr 2021 19:50:33 -0400

 I see two issues with the change set that was pushed. The first is
 simply that if the package expects xdg-open to be available, then it
 should explicitly depend on misc/xdg-utils, which provides it.
 The second is that one of the two patches may not work as expected.
 You have this:
 +--- shell/source/unix/misc/     2021-03-24 16:28:10.000000000 +0000
 ++++ shell/source/unix/misc/
 +@@ -393,6 +393,8 @@ case $(basename "$MAILER" | sed 's/-.*$/
 +             MAILER=/usr/bin/kde-open
 +         elif [ -x /usr/bin/xdg-open ] ; then
 +             MAILER=/usr/bin/xdg-open
 ++        elif type -p xdg-open >/dev/null 2>&1 ; then
 ++            MAILER="$(type -p xdg-open)"
 +         else
 +             echo "Unsupported mail client: $(basename $MAILER | sed 's/-.*^//')"
 +             exit 2
 "type -p" will not work as expected with NetBSD's /bin/sh (and with
 certain other versions). Please see PR bin/54803 (where kre@ recommended
 using "command -v" instead).

Home | Main Index | Thread Index | Old Index