pkg/56049: archivers/star installs gnutar symlink which breaks things

[Hauke Fath <hf%spg.tu-darmstadt.de@localhost>]

>Number:         56049
>Category:       pkg
>Synopsis:       archivers/star installs gnutar symlink which breaks things
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 09 15:10:00 +0000 2021
>Originator:     Hauke Fath
>Release:        NetBSD 9.99.80
>Organization:
Technische Universitaet Darmstadt
>Environment:
	
	
System: NetBSD Gstoder 9.99.80 NetBSD 9.99.80 (GA-MA770-UD3-$Revision$) #0: Thu Mar 4 16:26:35 CET 2021 hf@Hochstuhl:/var/obj/netbsd-builds/developer/amd64/sys/arch/amd64/compile/GA-MA770-UD3 amd64
Architecture: x86_64
Machine: amd64
>Description:

	During pkg_rolling-replace(8) runs, the firefox build started to break with a peculiar

[...]
../../config/nsinstall -D /var/obj/pkgsrc/www/firefox/work/.destdir/usr/pkg/lib/firefox
(cd ../../dist/firefox && /usr/pkg/bin/gnutar --exclude=precomplete --exclude=.mkdir.done -chf - .) | \
  (cd /var/obj/pkgsrc/www/firefox/work/.destdir/usr/pkg/lib/firefox && tar -xf -)
gnutar: Bad Option: -chf.
Usage:  gnutar cmd [options] file1 ... filen

Use     gnutar --help
and     gnutar --xhelp
to get a list of valid cmds and options.

Use     gnutar -H help
to get a list of valid archive header formats.

For a more complete user interface use the star type command interface.
See 'man star'. The gnutar command is more or less limited to the
GNU tar command line interface.
tar: Hard EOF on input, first EOF block is missing at -1.

	Turned out the recently installed archivers/star installs a
	"gnutar" symlink

% ls -l /usr/pkg/bin/*tar
-rwxr-xr-x  1 root  wheel  750872 Jun  5  2020 /usr/pkg/bin/bsdtar
lrwxr-xr-x  1 root  wheel       4 Mar  1 14:29 /usr/pkg/bin/gnutar -> star
-rwxr-xr-x  1 root  wheel  551512 Mar  7 19:27 /usr/pkg/bin/gtar
lrwxr-xr-x  1 root  wheel      21 Mar  8 01:05 /usr/pkg/bin/ptar -> ../lib/perl5/bin/ptar
-rwxr-xr-x  1 root  wheel  475968 Mar  1 14:29 /usr/pkg/bin/star
lrwxr-xr-x  1 root  wheel       4 Mar  1 14:29 /usr/pkg/bin/suntar -> star
lrwxr-xr-x  1 root  wheel       4 Mar  1 14:29 /usr/pkg/bin/tar -> star
lrwxr-xr-x  1 root  wheel       4 Mar  1 14:29 /usr/pkg/bin/ustar -> star
%

	which is picked up as GNU tar by the firefox build, but fails
	to meet the expectations.

	
>How-To-Repeat:

	With $PREFIX/bin first in PATH, install star, then build firefox.

	
>Fix:

	IDK - either tell builds that expect GNU tar to look for gtar
	proper, or slap star's wrist for pretending what it is not.

	

>Unformatted: