pkg/56038: databases/lmdb fails to compile on Solaris 10u7 w/ SunStudio 12u1

[mdehling%gmail.com@localhost]

>Number:         56038
>Category:       pkg
>Synopsis:       databases/lmdb fails to compile on Solaris 10u7 w/ SunStudio 12u1
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 04 22:30:00 +0000 2021
>Originator:     Malte Dehling
>Release:        pkgsrc-2020Q4
>Organization:
>Environment:
SunOS deuterium 5.10 Generic_139555-08 sun4u sparc sun4u
cc: Sun C 5.10 SunOS_sparc 2009/06/03

>Description:
Building databases/lmdb fails with a missing symbol fdatasync.
>How-To-Repeat:

>Fix:
On Solaris 10 fdatasync is defined in /usr/lib/64/librt.so.1, so simply adding -lrt to LDFLAGS.SunOS works.  This should work for older versions as well.

A quick google search seems to indicate that -lrt is not required in Solaris 11.

The following patch works for me, though I'm not convinced the test for OS_VERSION below is the right thing to do here.


--- Makefile.orig       Thu Mar  4 22:32:49 2021
+++ Makefile    Thu Mar  4 23:26:13 2021
@@ -27,6 +27,11 @@
 TEST_TARGET=           test
 
 .include "../../mk/bsd.prefs.mk"
+
+.if ${OPSYS} == "SunOS" && ${OS_VERSION} != "5.11"
+LDFLAGS+=              -lrt
+.endif
+
 .if ${OPSYS} == "Darwin"
 MAKE_FLAGS+=   SOEXT=.dylib
 MAKE_FLAGS+=   SOLIBS=-install_name\ ${PREFIX}/lib/liblmdb.dylib