pkg/55927: net/net-snmp: net-snmp: Outdate symlinks for Darwin

[dmarquess%gmail.com@localhost]

>Number:         55927
>Category:       pkg
>Synopsis:       net/net-snmp: net-snmp: Outdate symlinks for Darwin
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 14 05:50:00 +0000 2021
>Originator:     Dustin Marquess
>Release:        pkgsrc-current: 2021-01-14
>Organization:
>Environment:
Darwin relativity.local 20.4.0 Darwin Kernel Version 20.4.0: Sun Jan 10 18:07:35 PST 2021; root:xnu-7195.100.279.0.2~9 x86_64
>Description:
The pkgsrc Makefile attempts to symlink older Darwin headers in order to add support for newer versions of Darwin.  However the package seems to include a few of those versions now, so ln fails.

We need to:

- Remove the l4, 15, 16, 17 symlinks
- Repoint the 18 & 19 symlinks to the newer 17 version and not the older 15 version
- Add a 20 symlink
>How-To-Repeat:
Attempt to build net-snmp on Darwin
>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/net/net-snmp/Makefile,v
retrieving revision 1.135
diff -U 5 -r1.135 Makefile
--- Makefile	6 Nov 2020 08:52:40 -0000	1.135
+++ Makefile	14 Jan 2021 05:47:49 -0000
@@ -119,16 +119,13 @@
 post-extract:
 .if ${OPSYS} == "DragonFly"
 	cp ${FILESDIR}/cpu_dragonfly.c ${WRKSRC}/agent/mibgroup/hardware/cpu/cpu_nlist.c
 # XXX make it build on OS X 10.10; remove on the next update
 .elif ${OPSYS} == "Darwin"
-	${LN} -s ${WRKSRC}/include/net-snmp/system/darwin13.h ${WRKSRC}/include/net-snmp/system/darwin14.h
-	${LN} -s ${WRKSRC}/include/net-snmp/system/darwin13.h ${WRKSRC}/include/net-snmp/system/darwin15.h
-	${LN} -s ${WRKSRC}/include/net-snmp/system/darwin13.h ${WRKSRC}/include/net-snmp/system/darwin16.h
-	${LN} -s ${WRKSRC}/include/net-snmp/system/darwin13.h ${WRKSRC}/include/net-snmp/system/darwin17.h
-	${LN} -s ${WRKSRC}/include/net-snmp/system/darwin13.h ${WRKSRC}/include/net-snmp/system/darwin18.h
-	${LN} -s ${WRKSRC}/include/net-snmp/system/darwin13.h ${WRKSRC}/include/net-snmp/system/darwin19.h
+	${LN} -s ${WRKSRC}/include/net-snmp/system/darwin17.h ${WRKSRC}/include/net-snmp/system/darwin18.h
+	${LN} -s ${WRKSRC}/include/net-snmp/system/darwin17.h ${WRKSRC}/include/net-snmp/system/darwin19.h
+	${LN} -s ${WRKSRC}/include/net-snmp/system/darwin17.h ${WRKSRC}/include/net-snmp/system/darwin20.h
 .endif

 post-wrapper:
 .if !empty(MACHINE_PLATFORM:MNetBSD-1.5.[123]*-i386)
 	mkdir ${BUILDLINK_DIR}/include/sys