Re: pkg/55593: Proposed modification to buildlink3.mk of libxml2

[Jonathan Perkin <jperkin%joyent.com@localhost>]

The following reply was made to PR pkg/55593; it has been noted by GNATS.

From: Jonathan Perkin <jperkin%joyent.com@localhost>
To: Joerg Sonnenberger <joerg%bec.de@localhost>
Cc: gnats-bugs%netbsd.org@localhost, pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
	pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/55593: Proposed modification to buildlink3.mk of libxml2
Date: Fri, 28 Aug 2020 16:05:09 +0100

 * On 2020-08-21 at 18:59 BST, Joerg Sonnenberger wrote:
 
 > On Thu, Aug 20, 2020 at 03:40:00AM +0000, you.kawasaki%gmail.com@localhost wrote:
 > > I noticed that the CFLAG does not include "include/libxml2".
 > > When I added following line in buildlink3.mk of libxml2 to include "include/libxml2" in the CFLAG, building finished without an error for handbrake.
 > 
 > So the short version is that this $#%^$%^$%^ hardcodes include paths for
 > various systems and for Linux it falls through to explicitly using
 > /usr/include. It should be using pkg-config like everyone... libxml2's
 > b3.mk should most definitely not be changed for compensating for such a
 > mess.
 
 FWIW I just ran into this on a system building www/nginx also.
 
 I don't see any _harm_ in adding the correct INCDIRS, it's what we do
 for a lot of other packages, so I'm going to add it unless there are
 serious objections.
 
 -- 
 Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com