pkg/55284: 'wmweather' broken on architecture where sizeof(long) < sizeof(time_t)

[romain%dolbeau..org@localhost]

>Number:         55284
>Category:       pkg
>Synopsis:       'wmweather' broken on architecture where sizeof(long) < sizeof(time_t)
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 22 14:00:00 +0000 2020
>Originator:     Romain Dolbeau
>Release:        pkgsrc 2020Q1
>Organization:
-
>Environment:
NetBSD ss20.dolbeau.name 9.0 NetBSD 9.0 (GENERIC.MP) #0: Fri Feb 14 00:06:28 UTC 2020  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/sparc/compile/GENERIC.MP sparc
>Description:
'wmweather' is broken on architecture where sizeof(long) < sizeof(time_t), as it passes a pointer to a 'long' (4 bytes on NetBSD/sparc) to time(), which takes a pointer to a time_t (8 bytes).

On NetBSD/sparc said long is not 8-bytes aligned, leading to a 'Bus error' due to a misaligned load (rather than a stack corruption).
>How-To-Repeat:
start wmweather on NetBSD/sparc -> Bus error.
>Fix:
I have a patch that I will submit in a follow-up e-mail, which introduce an extra time_t variable to avoid the issue.