pkg/55209: Guide fails when copying example rc.d files

[samuel%offscale.io@localhost]

>Number:         55209
>Category:       pkg
>Synopsis:       Guide fails when copying example rc.d files
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 26 08:55:00 +0000 2020
>Originator:     Samuel Marks
>Release:        9.0
>Organization:
Offscale.io (Sydney Scientific Pty Ltd)
>Environment:
N/A
>Description:
https://netbsd.org/docs/guide/en/chap-x.html#chap-x-other-window-managers
>How-To-Repeat:
Specifically I don't have /usr/pkg/share/examples/rc.d/famd in NetBSD 9.0. But maybe other versions do, so I've written a little loop that checks
>Fix:
Index: docs/guide/download/netbsd-en.txt
===================================================================
RCS file: /cvsroot/htdocs/docs/guide/download/netbsd-en.txt,v
retrieving revision 1.35
diff -u -r1.35 netbsd-en.txt
--- docs/guide/download/netbsd-en.txt	14 Apr 2020 13:08:15 -0000	1.35
+++ docs/guide/download/netbsd-en.txt	26 Apr 2020 07:10:22 -0000
@@ -4229,17 +4229,16 @@
 how to use the Xfce desktop environment.
 
 # pkg_add -v xfce4
-# cp /usr/pkg/share/examples/rc.d/famd /etc/rc.d
-# cp /usr/pkg/share/examples/rc.d/dbus /etc/rc.d
-# cp /usr/pkg/share/examples/rc.d/hal /etc/rc.d
 # echo rpcbind=YES >> /etc/rc.conf
-# echo famd=YES >> /etc/rc.conf
-# echo dbus=YES >> /etc/rc.conf
-# echo hal=YES >> /etc/rc.conf
 # /etc/rc.d/rpcbind start
-# /etc/rc.d/famd start
-# /etc/rc.d/dbus start
-# /etc/rc.d/hal start
+# for n in famd dbus hal; do \
+    f='/usr/pkg/share/examples/rc.d/'"$n"; \
+    if [ -f "$f" ]; then
+      cp -v "$f" /etc/rc.d/;
+      echo "$n"'=YES' >> /etc/rc.conf;
+      /etc/rc.d/"$n" start;
+    fi \
+done
 
 After running the above commands, edit your .xinitrc as above and change "
 openbox" (or "twm") to "xfce4-session". The next time you run startx the Xfce
Index: docs/guide/en/chap-x.html
===================================================================
RCS file: /cvsroot/htdocs/docs/guide/en/chap-x.html,v
retrieving revision 1.34
diff -u -r1.34 chap-x.html
--- docs/guide/en/chap-x.html	2 Apr 2020 11:10:17 -0000	1.34
+++ docs/guide/en/chap-x.html	26 Apr 2020 07:10:22 -0000
@@ -226,18 +226,20 @@
       </p>
 <p>Installing a desktop environment is almost as easy.  The following
      example shows how to use the Xfce desktop environment.</p>
-<pre class="screen"><code class="prompt">#</code> <strong class="userinput"><code>pkg_add -v xfce4</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>cp /usr/pkg/share/examples/rc.d/famd /etc/rc.d</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>cp /usr/pkg/share/examples/rc.d/dbus /etc/rc.d</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>cp /usr/pkg/share/examples/rc.d/hal /etc/rc.d</code></strong>
+<pre class="screen">
+<code class="prompt">#</code> <strong class="userinput"><code>pkg_add -v xfce4</code></strong>
 <code class="prompt">#</code> <strong class="userinput"><code>echo rpcbind=YES &gt;&gt; /etc/rc.conf</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>echo famd=YES &gt;&gt; /etc/rc.conf</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>echo dbus=YES &gt;&gt; /etc/rc.conf</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>echo hal=YES &gt;&gt; /etc/rc.conf</code></strong>
 <code class="prompt">#</code> <strong class="userinput"><code>/etc/rc.d/rpcbind start</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>/etc/rc.d/famd start</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>/etc/rc.d/dbus start</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>/etc/rc.d/hal start</code></strong></pre>
+<code class="prompt">#</code> <strong class="userinput"><code>cp /usr/pkg/share/examples/rc.d/hal /etc/rc.d</code></strong>
+<code class="prompt">#</code> <strong class="userinput"><code>for n in famd dbus hal; do \
+    f=&#x27;/usr/pkg/share/examples/rc.d/&#x27;&#x22;$n&#x22;; \
+    if [ -f &#x22;$f&#x22; ]; then
+      cp -v &#x22;$f&#x22; /etc/rc.d/;
+      echo &#x22;$n&#x22;&#x27;=YES&#x27; &#x3E;&#x3E; /etc/rc.conf;
+      /etc/rc.d/&#x22;$n&#x22; start;
+    fi \
+done</code></strong>
+</pre>
 <p>After running the above commands, edit your
       <code class="filename">.xinitrc</code> as above and change
       <span class="quote">&#8220;<span class="quote">openbox</span>&#8221;</span> (or <span class="quote">&#8220;<span class="quote">twm</span>&#8221;</span>) to
Index: docs/guide/en/netbsd.html
===================================================================
RCS file: /cvsroot/htdocs/docs/guide/en/netbsd.html,v
retrieving revision 1.234
diff -u -r1.234 netbsd.html
--- docs/guide/en/netbsd.html	14 Apr 2020 13:08:16 -0000	1.234
+++ docs/guide/en/netbsd.html	26 Apr 2020 07:10:26 -0000
@@ -4660,18 +4660,20 @@
       </p>
 <p>Installing a desktop environment is almost as easy.  The following
      example shows how to use the Xfce desktop environment.</p>
-<pre class="screen"><code class="prompt">#</code> <strong class="userinput"><code>pkg_add -v xfce4</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>cp /usr/pkg/share/examples/rc.d/famd /etc/rc.d</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>cp /usr/pkg/share/examples/rc.d/dbus /etc/rc.d</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>cp /usr/pkg/share/examples/rc.d/hal /etc/rc.d</code></strong>
+<pre class="screen">
+<code class="prompt">#</code> <strong class="userinput"><code>pkg_add -v xfce4</code></strong>
 <code class="prompt">#</code> <strong class="userinput"><code>echo rpcbind=YES &gt;&gt; /etc/rc.conf</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>echo famd=YES &gt;&gt; /etc/rc.conf</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>echo dbus=YES &gt;&gt; /etc/rc.conf</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>echo hal=YES &gt;&gt; /etc/rc.conf</code></strong>
 <code class="prompt">#</code> <strong class="userinput"><code>/etc/rc.d/rpcbind start</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>/etc/rc.d/famd start</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>/etc/rc.d/dbus start</code></strong>
-<code class="prompt">#</code> <strong class="userinput"><code>/etc/rc.d/hal start</code></strong></pre>
+<code class="prompt">#</code> <strong class="userinput"><code>cp /usr/pkg/share/examples/rc.d/hal /etc/rc.d</code></strong>
+<code class="prompt">#</code> <strong class="userinput"><code>for n in famd dbus hal; do \
+    f=&#x27;/usr/pkg/share/examples/rc.d/&#x27;&#x22;$n&#x22;; \
+    if [ -f &#x22;$f&#x22; ]; then
+      cp -v &#x22;$f&#x22; /etc/rc.d/;
+      echo &#x22;$n&#x22;&#x27;=YES&#x27; &#x3E;&#x3E; /etc/rc.conf;
+      /etc/rc.d/&#x22;$n&#x22; start;
+    fi \
+done</code></strong>
+</pre>
 <p>After running the above commands, edit your
       <code class="filename">.xinitrc</code> as above and change
       <span class="quote">&#8220;<span class="quote">openbox</span>&#8221;</span> (or <span class="quote">&#8220;<span class="quote">twm</span>&#8221;</span>) to
Index: docs/guide/en/chap-x.xml
===================================================================
RCS file: /cvsroot/htdocs/docs/guide/en/chap-x.xml,v
retrieving revision 1.10
diff -u -r1.10 chap-x.xml
--- docs/guide/en/chap-x.xml	20 Apr 2019 08:44:17 -0000	1.10
+++ docs/guide/en/chap-x.xml	26 Apr 2020 07:10:26 -0000
@@ -252,17 +252,18 @@
      example shows how to use the Xfce desktop environment.</para>
 
    <screen>&rprompt; <userinput>pkg_add -v xfce4</userinput>
-&rprompt; <userinput>cp /usr/pkg/share/examples/rc.d/famd /etc/rc.d</userinput>
-&rprompt; <userinput>cp /usr/pkg/share/examples/rc.d/dbus /etc/rc.d</userinput>
-&rprompt; <userinput>cp /usr/pkg/share/examples/rc.d/hal /etc/rc.d</userinput>
 &rprompt; <userinput>echo rpcbind=YES &gt;&gt; /etc/rc.conf</userinput>
-&rprompt; <userinput>echo famd=YES &gt;&gt; /etc/rc.conf</userinput>
-&rprompt; <userinput>echo dbus=YES &gt;&gt; /etc/rc.conf</userinput>
-&rprompt; <userinput>echo hal=YES &gt;&gt; /etc/rc.conf</userinput>
 &rprompt; <userinput>/etc/rc.d/rpcbind start</userinput>
-&rprompt; <userinput>/etc/rc.d/famd start</userinput>
-&rprompt; <userinput>/etc/rc.d/dbus start</userinput>
-&rprompt; <userinput>/etc/rc.d/hal start</userinput></screen>
+&rprompt; <userinput>cp /usr/pkg/share/examples/rc.d/hal /etc/rc.d</userinput>
+&rprompt; <userinput>for n in famd dbus hal; do \
+    f=&#x27;/usr/pkg/share/examples/rc.d/&#x27;&#x22;$n&#x22;; \
+    if [ -f &#x22;$f&#x22; ]; then
+      cp -v &#x22;$f&#x22; /etc/rc.d/;
+      echo &#x22;$n&#x22;&#x27;=YES&#x27; &#x3E;&#x3E; /etc/rc.conf;
+      /etc/rc.d/&#x22;$n&#x22; start;
+    fi \
+done</userinput>
+</screen>
 
     <para>After running the above commands, edit your
       <filename>.xinitrc</filename> as above and change