pkg/55181: pkgsrc/www/firefox 75.0 build error on NetBSD/i386 9.0

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         55181
>Category:       pkg
>Synopsis:       pkgsrc/www/firefox 75.0 build error on NetBSD/i386 9.0
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 15 16:45:00 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0 + pkgsrc-2020Q1 + firefox 75.0 (pulled from HEAD)
>Organization:
>Environment:
System: NetBSD optiplex 9.0 NetBSD 9.0 (GENERIC) #0: Fri Feb 14 00:06:28 UTC 2020  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
On NetBSD/i386 9.0, building pkgsrc/www/firefox 75.0 caused
the following error:

---
 :
/s/obj.i386/pkgsrc/www/firefox/work.i386/.cwrapper/bin/gcc -o emms_mmx.o -c  -I/s/obj.i386/pkgsrc/www/firefox/work.i386/build/dist/system_wrappers -include /s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-75.0/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DHAVE_CONFIG_H=vpx_config.h -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-75.0/media/libvpx -I/s/obj.i386/pkgsrc/www/firefox/work.i386/build/media/libvpx -I/s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-75.0/media/libvpx/config/linux/ia32 -I/s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-75.0/media/libvpx/config -I/s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-75.0/media/libvpx/libvpx -I/s/obj.i386/pkgsrc/www/firefox/work.i386/build/dist/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss -I/usr/pkg/include/nspr -I/s/obj.i386/pkgsrc/www/firefox/work.i386/build/dist/inclu!
 de/nss -I/usr/X11R7/include/pixman-1 -fPIC -DPIC -include /s/obj.i386/pkgsrc/www/firefox/work.i386/build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/X11R7/include/freetype2 -O2 -D_GLIBCXX_INCLUDE_NEXT_C_HEADERS -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/X11R7/include/freetype2 -fno-strict-aliasing -Dunix -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -I/usr/pkg/include -O2 -fomit-frame-pointer -funwind-tables -Qunused-arguments -Wall -Wbitfield-enum-conversi!
 on -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-!
 field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-sign-compare -Wno-unused-function -Wno-unreachable-code -Wno-unneeded-internal-declaration  -MD -MP -MF .deps/emms_mmx.o.pp   /s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-75.0/media/libvpx/libvpx/vpx_ports/emms_mmx.c
media/libvpx/gen_scalers.o
/s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-75.0/media/libvpx/libvpx/vpx_ports/emms_mmx.c:15:33: error: always_inline function '_mm_empty' requires target feature 'mmx', but would be inlined into function 'vpx_clear_system_state' that is compiled without support for 'mmx'
void vpx_clear_system_state() { _mm_empty(); }
                                ^
1 error generated.
gmake[3]: *** [/s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-75.0/config/rules.mk:673: emms_mmx.o] Error 1
gmake[3]: Leaving directory '/s/obj.i386/pkgsrc/www/firefox/work.i386/build/media/libvpx'
gmake[2]: *** [/s/obj.i386/pkgsrc/www/firefox/work.i386/firefox-75.0/config/recurse.mk:74: media/libvpx/target-objects] Error 2
 :
---

>How-To-Repeat:
Build pkgsrc firefox 75.0 on NetBSD/i386 9.0, as mentioned above.

>Fix:
It looks the following patch (as patches/patch-media_libvpx_moz.build)
appeases the error (but I'm not sure why it worked on 74.0 and prior):

---
$NetBSD$

- workaround for build errors on NetBSD/i386 9.0.

--- media/libvpx/moz.build.orig	2020-04-03 19:35:03.000000000 +0000
+++ media/libvpx/moz.build
@@ -112,6 +112,8 @@ for f in SOURCES:
             SOURCES[f].flags += ['-mavx']
         if 'avx2.c' in f:
             SOURCES[f].flags += ['-mavx2']
+        if 'mmx.c' in f:
+            SOURCES[f].flags += ['-mmmx']
 
 # Suppress warnings in third-party code.
 CFLAGS += [