pkg/55079: sysupgrade: clean not remove the *.tar.xz files from cache directory

[kikadf.01%gmail.com@localhost]

>Number:         55079
>Category:       pkg
>Synopsis:       sysupgrade: clean not remove the *.tar.xz files from cache directory
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 17 14:00:00 +0000 2020
>Originator:     kikadf
>Release:        9.0
>Organization:
>Environment:
>Description:
sysupgrade-1.5nb4 patched to support the new tar.xz archive format, but in the clean function, only remove the *gz* files from cache dir. This cause at next upgrade, the sysupgrade fetch don't download the new xz files, just reuse the old components.

Links:
1. bug report: https://github.com/jmmv/sysupgrade/issues/9
2. patch: https://github.com/kikadf/sysupgrade/commit/b2a7e21cc8c7302720904358b5a124b4d1949a43
3. pull request to the xz support patch: https://github.com/triaxx/sysupgrade/pull/1

cc: jmmv, triaxx

>How-To-Repeat:
On NetBSD-9:

# sysupgrade auto [daily-url snapshot1]
# ls /var/cache/sysupgrade
# sysupgrade auto [daily-url snapshot2]

>Fix:
>From b2a7e21cc8c7302720904358b5a124b4d1949a43 Mon Sep 17 00:00:00 2001
From: kikadf <kikadf.01%gmail.com@localhost>
Date: Mon, 16 Mar 2020 13:20:13 +0100
Subject: [PATCH] Fix clean: remove *.tar.xz files

---
 sysupgrade.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sysupgrade.sh b/sysupgrade.sh
index 2434065..191f3da 100644
--- a/sysupgrade.sh
+++ b/sysupgrade.sh
@@ -432,6 +432,7 @@ sysupgrade_clean() {
 
     shtk_cli_info "Cleaning downloaded files"
     rm -f "$(shtk_config_get CACHEDIR)"/*.*gz*
+    rm -f "$(shtk_config_get CACHEDIR)"/*.${arch_ext}*
 }