pkg/55065: misc/tmux fails to compile on Solaris

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         55065
>Category:       pkg
>Synopsis:       misc/tmux fails to compile on Solaris
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 12 08:10:01 +0000 2020
>Originator:     Joern Clausen
>Release:        
>Organization:
Bielefeld University
>Environment:
>Description:
misc/tmux fails to compile on Solaris. tmux/compat.h assumes that paths.h always defines _PATH_DEFPATH, which is not the case on Solaris.

This has been fixed on Github, but so far only a release candidate of tmux is available. The attached replacement for patches/patch-compat.h (based on the code on Github) fixes the build, until tmux-3.1 is released. 
>How-To-Repeat:

>Fix:
--- compat.h.orig       2019-06-26 11:26:30.000000000 +0000
+++ compat.h
@@ -61,13 +61,32 @@ void        warn(const char *, ...);
 void   warnx(const char *, ...);
 #endif
 
-#ifndef HAVE_PATHS_H
-#define        _PATH_BSHELL    "/bin/sh"
-#define        _PATH_TMP       "/tmp/"
-#define _PATH_DEVNULL  "/dev/null"
-#define _PATH_TTY      "/dev/tty"
-#define _PATH_DEV      "/dev/"
-#define _PATH_DEFPATH  "/usr/bin:/bin"
+#ifdef HAVE_PATHS_H
+#include <paths.h>
+#endif
+
+#ifndef _PATH_BSHELL
+#define _PATH_BSHELL "/bin/sh"
+#endif
+
+#ifndef _PATH_TMP
+#define _PATH_TMP "/tmp/"
+#endif
+
+#ifndef _PATH_DEVNULL
+#define _PATH_DEVNULL "/dev/null"
+#endif
+
+#ifndef _PATH_TTY
+#define _PATH_TTY "/dev/tty"
+#endif
+
+#ifndef _PATH_DEV
+#define _PATH_DEV "/dev/"
+#endif
+
+#ifndef _PATH_DEFPATH
+#define _PATH_DEFPATH "/usr/bin:/bin"
 #endif
 
 #ifndef __OpenBSD__
@@ -98,10 +117,6 @@ void        warnx(const char *, ...);
 #include "compat/bitstring.h"
 #endif
 
-#ifdef HAVE_PATHS_H
-#include <paths.h>
-#endif
-
 #ifdef HAVE_LIBUTIL_H
 #include <libutil.h>
 #endif
@@ -154,6 +169,14 @@ void       warnx(const char *, ...);
 #define O_DIRECTORY 0
 #endif
 
+#ifndef FNM_CASEFOLD
+#ifdef FNM_IGNORECASE
+#define FNM_CASEFOLD FNM_IGNORECASE
+#else
+#define FNM_CASEFOLD 0
+#endif
+#endif
+
 #ifndef INFTIM
 #define INFTIM -1
 #endif