Re: pkg/55049: emulators/qemu build fail after merge nvmm on netbsd/amd64-8

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/55049; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/55049: emulators/qemu build fail after merge nvmm on netbsd/amd64-8
Date: Thu, 05 Mar 2020 17:36:34 +0100

 Hello Yasushi, 
 
 oshima-ya%yagoto-urayama.jp@localhost writes:
 > [...]
 > >Description:
 > The nvmm patch for qemu always enables nvmm option when OS is NetBSD.
 > But nvmm is only available on NetBSD/amd64 9.0 and later now.
 >
 > When in the case of another version, (netbsd/amd64-8, netbsd/i386-any, or so on), make configure says:
 >
 > ERROR: User requested feature NVMM
 >        configure was not able to find it.
 >        NVMM is not available
 >
 > *** Error code 1
 >
 > Stop.
 > make[1]: stopped in /usr/pkgsrc/emulators/qemu
 > *** Error code 1
 > 
 > Stop.
 > make: stopped in /usr/pkgsrc/emulators/qemu
 >
 > >How-To-Repeat:
 > make in pkgsrc/emulators/qemu on NetBSD/amd64 8.1
 >
 > >Fix:
 > This patch change to:
 > - Set default off when netbsd.
 > - Add nvmm PKG_OPTION when NetBSD/amd64 9 and later.
 >   - add --enable-nvmm CONFIGURE_ARGS.
 >   - another case, add --disable-nvmm.
 > It will need more considerations for other OS cases.
 > [...]
 
 What about just adjusting the patches/patch-configure as follow:
 
 > [...]
 > diff --git a/emulators/qemu/patches/patch-configure b/emulators/qemu/patches/patch-configure
 > index e2900d98e9a..8eb5631cd6d 100644
 > --- a/emulators/qemu/patches/patch-configure
 > +++ b/emulators/qemu/patches/patch-configure
 > @@ -43,7 +43,7 @@ Add NVMM support.
 >   NetBSD)
 >     bsd="yes"
 >     hax="yes"
 > -+  nvmm="yes"
 > ++  nvmm="no"
 >     make="${MAKE-gmake}"
 >     audio_drv_list="oss try-sdl"
 >     audio_possible_drivers="oss sdl"
 >
 
 ...instead of `nvmm="yes"' or `nvmm="no"' it can be set to:
 
  nvmm=""
 
 so in that way nvmm will be enabled only if available.