Re: kern/53490 (sysutils/grub2: module loaded even if feature is builtin)

[Paul Goyette <paul%whooppee.com@localhost>]

The following reply was made to PR pkg/53490; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: triaxx%NetBSD.org@localhost
Subject: Re: kern/53490 (sysutils/grub2: module loaded even if feature is
 builtin)
Date: Tue, 21 Jan 2020 08:09:28 -0800 (PST)

 I will leave any changes to the sysutils/grub2 package to you, as I am
 still unable to get a working package built.
 
 
 > A solution could be to inspect kernel config during grub-mkconfig
 > through helper script:
 >
 > $NetBSD$
 >
 > --- util/grub.d/10_netbsd.in.orig 2016-02-28 14:22:21.000000000 +0000
 > +++ util/grub.d/10_netbsd.in
 > @@ -68,8 +68,9 @@ netbsd_load_fs_module ()
 >
 >    kversion=$(zcat -f "${kernel}" | strings | sed -n -e '/^@(#)NetBSD/ { s/^@(#)NetBSD \([0-9\.]*\) .*$/\1/g ; p ; q ; }')
 >    kmodule="/stand/${karch}/${kversion}/modules/${kmod}/${kmod}.kmod"
 > +  builtin=$(if config -x /netbsd | grep "^file-system[[:space:]]*$(echo ${kmod} | tr [a-z] [A-Z])" > /dev/null 2>&1 ; then echo yes ; else echo no ; fi)
 >
 > -  if test -z "$karch" || test -z "$kversion" || test ! -f "${kmodule}"; then
 > +  if test -z "$karch" || test -z "$kversion" || test ! -f "${kmodule}" || test "x${builtin}" = "xyes" ; then
 >       return
 >    fi
 >
 
 
 
 
 +--------------------+--------------------------+-----------------------+
 | Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
 | (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
 | Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
 +--------------------+--------------------------+-----------------------+