Re: pkg/54752: devel/glib2 does not build on FreeBSD

[Frédéric Fauberteau <frederic%fauberteau.org@localhost>]

Envoyé depuis mon smartphone Samsung Galaxy.

-------- Message d'origine --------

De : Joerg Sonnenberger <joerg%bec.de@localhost>

Date : 28/12/2019 00:25 (GMT+01:00)

À : Frédéric Fauberteau <triaxx%NetBSD.org@localhost>

Cc : Joerg Sonnenberger <joerg%bec.de@localhost>, pkgsrc-bugs%netbsd.org@localhost

Objet : Re: pkg/54752: devel/glib2 does not build on FreeBSD

On Sat, Dec 28, 2019 at 12:21:36AM +0100, Frédéric Fauberteau wrote:
> Le 2019-12-28 00:15, Joerg Sonnenberger a écrit :
> >  On Fri, Dec 27, 2019 at 10:40:01PM +0000, Frédéric Fauberteau wrote:
> >  >  Clang leaves undefined the environ(7) symbol but it seems that it is
> >  >  resolved when a binary is linked to glib2. The error occurs either
> > using
> >  >  the basesystem's Clang-6.0.1 or the pkgsrc's one (Clang-9.0.0). I do
> > not
> >  >  know if the problem comes from Clang of FreeBSD. The following patch
> > fix
> >  >  the build error:
> > 
> >  Just mark environ locally as weak.
> 
> I do not know how to do that.

extern __attribute__((__weak__)) char **environ;
or so should do it, whereever they declare environ.

Joerg

Thanks! I will submit the fix upstream.

Fred