pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/54797: devel/lua-filesystem fails to buid due to missing lua link information



>Number:         54797
>Category:       pkg
>Synopsis:       devel/lua-filesystem fails to buid due to missing lua link information
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 25 02:15:00 +0000 2019
>Originator:     Jonathan Buschmann
>Release:        pkgsrc current tree 20191224
>Organization:
>Environment:
>Description:
Currently it fails to link as the patch for the config file contains a small mistake see the diff below that would fix it.

I did not check the commit made earlier this year otherwise I would have provided the patch earlier.

This contains some changes that may not be required, I'm talking about the usage of _LUA_DOT_VERSION
>How-To-Repeat:
Try to build devel/lua-filesystem
>Fix:
diff --git i/devel/lua-filesystem/Makefile w/devel/lua-filesystem/Makefile
index 32a735eac30..ab59c9282d8 100644
--- i/devel/lua-filesystem/Makefile
+++ w/devel/lua-filesystem/Makefile
@@ -21,7 +21,7 @@ BUILD_TARGET=         lib
 TEST_TARGET=           test
 
 MAKE_ENV+=             LUA_CDIR=${LUA_CDIR}
-MAKE_ENV+=             LUA_VERS=${LUA_VERSION_MAJOR}.${LUA_VERSION_MINOR}
+MAKE_ENV+=             LUA_VERS=${_LUA_DOT_VERSION}
 
 .include "../../lang/lua/module.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git i/devel/lua-filesystem/distinfo w/devel/lua-filesystem/distinfo
index fc084f89e6b..8c7ad24663c 100644
--- i/devel/lua-filesystem/distinfo
+++ w/devel/lua-filesystem/distinfo
@@ -5,4 +5,4 @@ RMD160 (luafilesystem-1.7.0.tar.gz) = 6770d25f1d0928c347560425d7c5758788038fd9
 SHA512 (luafilesystem-1.7.0.tar.gz) = a1d4d077776e57cd878dbcd21656da141ea3686c587b5420a2b039aeaf086b7e7d05d531ee1cc2bbd7d06660d1315b09593e52143f6711f033ce8eecdc550511
 Size (luafilesystem-1.7.0.tar.gz) = 30877 bytes
 SHA1 (patch-Makefile) = 1fd838ba0f5a716ed1f8f7b7ed4fda816e702806
-SHA1 (patch-config) = 5d459797960118aa387f1f5cfb8bc6d7923965c8
+SHA1 (patch-config) = d2b9aabe1196b100edbd7521517d49b5281d69cb
diff --git i/devel/lua-filesystem/patches/patch-config w/devel/lua-filesystem/patches/patch-config
index ed6a3a90ea6..1d7cbaef600 100644
--- i/devel/lua-filesystem/patches/patch-config
+++ w/devel/lua-filesystem/patches/patch-config
@@ -15,7 +15,7 @@ Try to find lua libs from pkgconfig, so we get RPATH specified.
  
  # System's libraries directory (where binary libraries are installed)
 -LUA_LIBDIR= $(PREFIX)/lib/lua/5.1
-+LUA_LIBS= $(pkg-config --libs lua-$(LUA_VERS))
++LUA_LIBS= $(shell pkg-config --libs lua-$(LUA_VERS))
 +LUA_LIBDIR= $(DESTDIR)$(PREFIX)/$(LUA_CDIR)
  
  # Lua includes directory



Home | Main Index | Thread Index | Old Index