pkg/54779: pkgsrc/audio/mpg123 for softfloat arm uses FPU

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         54779
>Category:       pkg
>Synopsis:       pkgsrc/audio/mpg123 for softfloat arm uses FPU
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 18 12:15:00 +0000 2019
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0_RC1 + pkgsrc-2019Q3
>Organization:
>Environment:
System: NetBSD 9.0_RC1
Architecture: earm
Machine: zaurus / evbarm
>Description:
pkgsrc/audio/mpg123/options.mk has the following statements to check
FPU options per ${MACHINE_ARCH}:
---
.if (${MACHINE_ARCH} == "i386")
.  if empty(MACHINE_PLATFORM:MDarwin-11.*-i386) && \
      empty(MACHINE_PLATFORM:MSunOS-*) && \
      empty(MACHINE_PLATFORM:MNetBSD-[89]*-i386)
PKG_OPTIONS_GROUP.fpu=		mpg123-x86-dither mpg123-with-fpu
PKG_SUGGESTED_OPTIONS+=		mpg123-x86-dither
.  else
PKG_OPTIONS_GROUP.fpu=		mpg123-with-fpu
PKG_SUGGESTED_OPTIONS+=		mpg123-with-fpu
.  endif
.elif (${MACHINE_ARCH} == "arm") || (${MACHINE_ARCH} == "arm32")
PKG_OPTIONS_GROUP.fpu=		mpg123-with-fpu 
.elif (${MACHINE_ARCH} == "aarch64")
PKG_OPTIONS_GROUP.fpu=		mpg123-neon64 mpg123-aarch64
PKG_SUGGESTED_OPTIONS+=		mpg123-aarch64
.elif (${MACHINE_ARCH} == "powerpc")
PKG_OPTIONS_GROUP.fpu=		mpg123-altivec mpg123-with-fpu
PKG_SUGGESTED_OPTIONS+=		mpg123-altivec
.else
PKG_OPTIONS_GROUP.fpu=		mpg123-with-fpu
PKG_SUGGESTED_OPTIONS+=		mpg123-with-fpu
.endif
---

> (${MACHINE_ARCH} == "arm") || (${MACHINE_ARCH} == "arm32")
This won't match for any new earm machines, so mpg123 for earm is build
with mpg123-with-fpu per the PKG_SUGGESTED_OPTIONS in the else clause,
then mpg123 binary (including mplayer with libmpg123) is almost
non-functional (i.e. choppy sound).

>How-To-Repeat:
Build mpg123 on earm and see SUGEESTED options.

>Fix:
Is there proper way to check "softfloat" using MACHINE_ARCH?

---
Izumi Tsutsui