pkg/54691: Compilation of tigervnc terminates with errors on Debian Linux 10.1

[you.kawasaki%gmail.com@localhost]

>Number:         54691
>Category:       pkg
>Synopsis:       Compilation of tigervnc terminates with errors on Debian Linux 10.1
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 11 21:45:00 +0000 2019
>Originator:     Yosuke Kawasaki
>Release:        pkgsrc-2019Q3
>Organization:
None
>Environment:
System: SMP Debian 4.19.67-2+deb10u1 (2019-09-20) x86_64 GNU/Linux
OS: Debian Linux 10.1
Architecture: x86_64

>Description:
The compilation of tigervnc stops with following errors.

===> Building for tigervnc-1.9.0nb3
[  2%] Built target network
[  6%] Built target os
[  6%] Built target Xregion
[  7%] Built target tx
[  9%] Built target unixcommon
[ 13%] Built target desktop
[ 24%] Built target translations
[ 24%] Built target test_util
[ 32%] Built target rdr
[ 70%] Built target rfb
[ 71%] Built target vncpasswd
[ 74%] Built target vncconfig
[ 75%] Built target convperf
[ 80%] Built target conv
[ 81%] Built target decperf
[ 84%] Built target fbperf
[ 85%] Built target hostport
[ 86%] Built target encperf
[ 91%] Built target x0vncserver
[100%] Built target vncviewer
Making all in doc
gmake[1]: Entering directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/doc'
Making all in dtrace
gmake[2]: Entering directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/doc/dtrace'
gmake[2]: Nothing to be done for 'all'.
gmake[2]: Leaving directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/doc/dtrace'
gmake[2]: Entering directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/doc'
gmake[2]: Nothing to be done for 'all-am'.
gmake[2]: Leaving directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/doc'
gmake[1]: Leaving directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/doc'
Making all in man
gmake[1]: Entering directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/man'
gmake[1]: Nothing to be done for 'all'.
gmake[1]: Leaving directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/man'
Making all in include
gmake[1]: Entering directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/include'
/var/pkg/bin/gmake  all-am
gmake[2]: Entering directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/include'
gmake[2]: Leaving directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/include'
gmake[1]: Leaving directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/include'
Making all in dix
...skipping...
WaitFor.c: In function 'WaitForSomething':
WaitFor.c:346:36: error: 'fd_set' {aka 'struct <anonymous>'} has no member named 'fds_bits'; did you mean '__fds_bits'?
             while (clientsReadable.fds_bits[i]) {
                                    ^~~~~~~~
                                    __fds_bits
WaitFor.c:349:50: error: 'fd_set' {aka 'struct <anonymous>'} has no member named 'fds_bits'; did you mean '__fds_bits'?
                 curclient = mffs(clientsReadable.fds_bits[i]) - 1;
                                                  ^~~~~~~~
                                                  __fds_bits
WaitFor.c:392:29: error: 'fd_set' {aka 'struct <anonymous>'} has no member named 'fds_bits'; did you mean '__fds_bits'?
             clientsReadable.fds_bits[i] &= ~(((fd_mask) 1L) << curclient);
                             ^~~~~~~~
                             __fds_bits
gmake[1]: *** [Makefile:707: WaitFor.lo] Error 1
connection.c: In function 'EstablishNewConnections':
connection.c:843:33: error: 'fd_set' {aka 'struct <anonymous>'} has no member named 'fds_bits'; did you mean '__fds_bits'?
         while (readyconnections.fds_bits[i])
                                 ^~~~~~~~
                                 __fds_bits
connection.c:852:41: error: 'fd_set' {aka 'struct <anonymous>'} has no member named 'fds_bits'; did you mean '__fds_bits'?
         curconn = mffs(readyconnections.fds_bits[i]) - 1;
                                         ^~~~~~~~
                                         __fds_bits
connection.c:853:26: error: 'fd_set' {aka 'struct <anonymous>'} has no member named 'fds_bits'; did you mean '__fds_bits'?
         readyconnections.fds_bits[i] &= ~((fd_mask) 1 << curconn);
                          ^~~~~~~~
                          __fds_bits
connection.c: In function 'CheckConnections':
connection.c:1011:27: error: 'fd_set' {aka 'struct <anonymous>'} has no member named 'fds_bits'; did you mean '__fds_bits'?
         mask = AllClients.fds_bits[i];
                           ^~~~~~~~
                           __fds_bits
gmake[1]: *** [Makefile:707: connection.lo] Error 1
gmake[1]: Leaving directory '/var/pkgsrc/work/net/tigervnc/work/tigervnc-1.9.0/unix/xserver/os'
gmake: *** [Makefile:780: all-recursive] Error 1
*** Error code 2

Stop.
bmake[1]: stopped in /usr/pkgsrc/net/tigervnc
*** Error code 1
Stop.
bmake: stopped in /usr/pkgsrc/net/tigervnc

>How-To-Repeat:
run make
>Fix:
It seems this error can be fixed by selecting appropriate structure member name  in /usr/include/features.h by defining "_XOPEN_SOURCE".

Inserting following line in Makefile has fixed the problem.
CFLAGS+=-D _XOPEN_SOURCE

Moreover, tigervnc needs xkeyboard-config for running vncserver.
Inserting following line in Makefile has fixed the problem.
.include "../../x11/xkeyboard-config/buildlink3.mk"

With above modification in Makefile, tigervnc has compiled and functioned smoothly on my machine.