Re: pkg/54631: devel/gettext-lib builtin.mk does not show builtin implementation of NetBSD

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

The following reply was made to PR pkg/54631; it has been noted by GNATS.

From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Fauberteau?= <triaxx%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54631: devel/gettext-lib builtin.mk does not show builtin
 implementation of NetBSD
Date: Mon, 21 Oct 2019 09:56:09 +0200

 Le 2019-10-21 09:45, triaxx%netbsd.org@localhost a écrit :
 >> Number:         54631
 >> Category:       pkg
 >> Synopsis:       devel/gettext-lib builtin.mk does not show builtin 
 >> implementation of NetBSD
 >> Confidential:   no
 >> Severity:       non-critical
 >> Priority:       low
 >> Responsible:    pkg-manager
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Mon Oct 21 07:45:00 +0000 2019
 >> Originator:     Fr�©d�©ric Fauberteau
 >> Release:        NetBSD 8.0 | pkgsrc-HEAD
 >> Organization:
 >> Environment:
 > System: NetBSD hydralisk.triaxx.org 8.0 NetBSD 8.0 (HYDRALISK) #0: Mon
 > Jan  7 23:57:12 CET 2019
 > root%hydralisk.triaxx.org@localhost:/mnt/ccd0/netbsd/obj.amd64/sys/arch/amd64/compile/HYDRALISK
 > amd64
 > Architecture: x86_64
 > Machine: amd64
 >> Description:
 > NetBSD seems to provide a buitin gettext implementation, but it is not
 > shown by devel/gettext-lib/builtin.mk as in the following example:
 > $ cd /usr/pkgsrc/devel/gmake && bmake show-var 
 > VARNAME=IS_BUILTIN.gettext
 > no
 >> How-To-Repeat:
 > On NetBSD, gmake does not link to /usr/lib/libintl.so.1:
 > $ cd /usr/pkgsrc/devel/gmake && bmake install
 > $ ldd /usr/pkg/bin/gmake
 > 
 > 
 > 
 > /usr/pkg/bin/gmake:
 >         -lc.12 => /usr/lib/libc.so.12
 >> Fix:
 > Index: builtin.mk
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/devel/gettext-lib/builtin.mk,v
 > retrieving revision 1.46
 > diff -u -r1.46 builtin.mk
 > --- builtin.mk  3 Jul 2014 14:59:55 -0000       1.46
 > +++ builtin.mk  21 Oct 2019 07:43:12 -0000
 > @@ -38,6 +38,8 @@
 >         empty(H_GETTEXT:M${LOCALBASE}/*)) || \
 >        (empty(H_GENTOO_GETTEXT:M__nonexistent__) && \
 >         empty(H_GENTOO_GETTEXT:M${LOCALBASE}/*)) || \
 > +      (empty(H_NGENTOO_GETTEXT:M__nonexistent__) && \
 > +       empty(H_NGENTOO_GETTEXT:M${LOCALBASE}/*)) || \
 >        (empty(H_OPNSVR5_GETTEXT:M__nonexistent__) && \
 >         empty(H_OPNSVR5_GETTEXT:M${LOCALBASE}/*))
 >  IS_BUILTIN.gettext=    yes
 
 Before committing such a patch, two questions:
    1) Why the following comment is prefixed by XXX (from 
 devel/gettext-lib/builtin.ml)? Is the assumption not totally right?
      # XXX
      # XXX By default, assume that the native gettext implementation is 
 good
      # XXX enough to replace GNU gettext if it supplies ngettext().
      # XXX
    2) If the patch is acceptable (and does not break things), I think 
 that a lot of packages which linked to pkgsrc gettext will now link to 
 native gettext. Should I bump revision of all packages that link to 
 gettext?