pkg/54573: x11/xfce4-desktop Needs CFLAGS+=-std=c99 to Build

[dplassche%gmail.com@localhost]

>Number:         54573
>Category:       pkg
>Synopsis:       x11/xfce4-desktop Needs CFLAGS+=-std=c99 to Build
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 25 21:45:00 +0000 2019
>Originator:     Dan Plassche
>Release:        pkgsrc-2019Q2
>Organization:
>Environment:
NetBSD 7.0.2 GENERIC i386
>Description:
xfce4-desktop throws the build error below.  The package builds successfully if you add CFLAGS+=-std=c99 to the Makefile.

Error:

gmake[3]: Entering directory '/usr/pkgsrc/x11/xfce4-desktop/work/xfdesktop-4.13.4/common'
  CC       libxfdesktop_la-xfdesktop-marshal.lo
  CC       libxfdesktop_la-tumbler.lo
  CC       libxfdesktop_la-xfdesktop-common.lo
xfdesktop-common.c: In function 'xfdesktop_get_screen_dimensions':
xfdesktop-common.c:270:5: error: 'for' loop initial declarations are only allowed in C99 mode
     for(int i = 0; i < num_monitors; i++) {
     ^
xfdesktop-common.c:270:5: note: use option -std=c99 or -std=gnu99 to compile your code
gmake[3]: *** [Makefile:538: libxfdesktop_la-xfdesktop-common.lo] Error 1
gmake[3]: Leaving directory '/usr/pkgsrc/x11/xfce4-desktop/work/xfdesktop-4.13.4/common'
gmake[2]: *** [Makefile:437: all] Error 2
gmake[2]: Leaving directory '/usr/pkgsrc/x11/xfce4-desktop/work/xfdesktop-4.13.4/common'
gmake[1]: *** [Makefile:575: all-recursive] Error 1

>How-To-Repeat:
Build xfce4-desktop
>Fix:
--- Makefile.def.bak	2019-05-22 23:04:16.000000000 -0400
+++ Makefile.new	2019-09-24 17:03:29.000000000 -0400
@@ -12,6 +12,7 @@
 COMMENT=	Xfce desktop background manager
 
 CONFIGURE_ARGS+=	--sysconfdir=${PKG_SYSCONFBASE}
+CFLAGS+=		-std=c99
 
 .include "../../devel/libglade/buildlink3.mk"
 .include "../../devel/libwnck3/buildlink3.mk"