pkg/54534: Pkgsrc patch to xf86drm.c ruines the code for linux

[you.kawasaki%gmail.com@localhost]

>Number:         54534
>Category:       pkg
>Synopsis:       Pkgsrc patch to xf86drm.c ruines the code for linux
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 08 15:15:00 +0000 2019
>Originator:     Yosuke Kawasaki
>Release:        pkgsrc-2019Q2
>Organization:
None
>Environment:
Linux debian-ss 4.19.0-5-amd64 #1 SMP Debian 4.19.37-5+deb10u2 (2019-08-08) x86_64 GNU/Linux
>Description:
The vainfo program is unfunctional on my linux environment and I found by gdb stepping that the pkgsrc patch-xf86drm.c erroneously damaged the code for linux when introducing the code for NetBSD.

Specifically, in drmParsePciBusInfo function of xf86drm.c, the patch inserts the NetBSD block before the final "return 0;" line of linux code block and thus drmParsePciBusInfo never returns 0.

You can see this in the end of NetBSD block in the patched file where the block ends with duplicated "return 0;"lines, one of which was from original linux block.
>How-To-Repeat:
Just build and run.
>Fix:
Fix the patch so that it correctly insert the NetBSD block after "return 0;" of linux block in drmParsePciBusInfo function in xf86drm.c