pkg/54464: editors/vim crashes with "Caught deadly signal ABRT" on Linux

[ottavio2006-usenet2012%yahoo.com@localhost]

>Number:         54464
>Category:       pkg
>Synopsis:       editors/vim crashes with "Caught deadly signal ABRT" on Linux
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 14 13:00:00 +0000 2019
>Originator:     Ottavio Caruso
>Release:        pkgsrc current
>Organization:
>Environment:
Linux e130 4.9.0-8-amd64 #1 SMP Debian 4.9.110-3+deb9u6 (2018-10-08) x86_64 GNU/Linux

>Description:
As reported on [1] and [2], when editors/vim is built on Linux, it creates and installs a package, but then it crashes at startup:

$vim
Vim: Caught deadly signal ABRT
Vim: Finished.

As per upstream's [2] response, they are adamant that this is due to pkgsrc using  -D_FORTIFY_SOURCE=2 and running into false positives.

While this approach may be debatable, it's clear that upstream think there's no bug involved here and won't debate the matter further.

References:
[1] https://mail-index.netbsd.org/pkgsrc-users/2019/07/10/msg028950.html
[2] https://groups.google.com/forum/#!topic/vim_use/FAHE5A_st-A
>How-To-Repeat:
$cd ~/pkgsrc/current/pkgsrc/editor/vim
$bmake install

$cd
$vim
Vim: Caught deadly signal ABRT
Vim: Finished.
>Fix:
This patch to editors/vim-share/Makefile.common sets:
PKGSRC_USE_FORTIFY= weak
on Linux


--- Makefile.common.old	2019-08-14 13:04:01.371682068 +0100
+++ Makefile.common	2019-08-14 13:32:27.903076508 +0100
@@ -52,6 +52,10 @@
 BUILDLINK_PASSTHRU_DIRS+=	/Developer/Headers/FlatCarbon
 .endif
 
+.if ${OPSYS} == "Linux"
+PKGSRC_USE_FORTIFY= weak
+.endif
+
 .if empty(PKGNAME:Mvim-share*)
 ALTERNATIVES_SRC=	${.CURDIR}/../../editors/vim-share/ALTERNATIVES
 .else