pkg/54462: security/tor-browser: error: visibility does not match previous declaration

[ng0%n0.is@localhost]

>Number:         54462
>Category:       pkg
>Synopsis:       security/tor-browser:  error: visibility does not match previous declaration
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 13 19:20:00 +0000 2019
>Originator:     ng0
>Release:        current, 2019-08-13
>Organization:
>Environment:
NetBSD uptimegirl 9.99.4 NetBSD 9.99.4 (GENERIC) amd64

>Description:
on a system with pkgsrc using clang from base, security/tor-browser-8.5.4 fails with:

In file included from /usr/work/security/tor-browser/work/firefox-tor-browser-60.8.0esr-8.5-1-build2/intl/hyphenation/glue/hnjstdio.cpp:13:
In file included from /usr/work/security/tor-browser/work/build/dist/include/nsNetUtil.h:10:
In file included from /usr/work/security/tor-browser/work/build/dist/include/mozilla/Maybe.h:22:
In file included from /usr/work/security/tor-browser/work/build/dist/stl_wrappers/ostream:44:
In file included from /usr/work/security/tor-browser/work/build/dist/system_wrappers/ostream:3:
In file included from /usr/include/c++/ostream:138:
In file included from /usr/work/security/tor-browser/work/build/dist/stl_wrappers/ios:44:
In file included from /usr/work/security/tor-browser/work/build/dist/system_wrappers/ios:3:
In file included from /usr/include/c++/ios:216:
In file included from /usr/include/c++/__locale:15:
In file included from /usr/work/security/tor-browser/work/build/dist/stl_wrappers/string:44:
In file included from /usr/work/security/tor-browser/work/build/dist/system_wrappers/string:3:
In file included from /usr/include/c++/string:437:
In file included from /usr/work/security/tor-browser/work/build/dist/stl_wrappers/cstdio:44:
In file included from /usr/work/security/tor-browser/work/build/dist/system_wrappers/cstdio:3:
/usr/include/c++/cstdio:130:77: error: no matching function for call to
      'hnjFeof'
  ...int __libcpp_feof(FILE* __stream) { return feof(__stream); }
                                                ^~~~~~~~~~~~~~
/usr/work/security/tor-browser/work/firefox-tor-browser-60.8.0esr-8.5-1-build2/intl/hyphenation/glue/hnjalloc.h:34:20: note: 
      expanded from macro 'feof'
#define feof(file) hnjFeof(file)
                   ^~~~~~~
/usr/work/security/tor-browser/work/firefox-tor-browser-60.8.0esr-8.5-1-build2/intl/hyphenation/glue/hnjalloc.h:49:5: note: 
      candidate function not viable: no known conversion from 'FILE *'
      (aka '__sFILE *') to 'hnjFile *' (aka 'hnjFile_ *') for 1st argument
int hnjFeof(hnjFile* f);
    ^
In file included from /usr/work/security/tor-browser/work/firefox-tor-browser-60.8.0esr-8.5-1-build2/intl/hyphenation/glue/hnjstdio.cpp:13:
In file included from /usr/work/security/tor-browser/work/build/dist/include/nsNetUtil.h:10:
In file included from /usr/work/security/tor-browser/work/build/dist/include/mozilla/Maybe.h:22:
In file included from /usr/work/security/tor-browser/work/build/dist/stl_wrappers/ostream:44:
In file included from /usr/work/security/tor-browser/work/build/dist/system_wrappers/ostream:3:
In file included from /usr/include/c++/ostream:138:
In file included from /usr/work/security/tor-browser/work/build/dist/stl_wrappers/ios:44:
In file included from /usr/work/security/tor-browser/work/build/dist/system_wrappers/ios:3:
In file included from /usr/include/c++/ios:216:
In file included from /usr/include/c++/__locale:15:
In file included from /usr/work/security/tor-browser/work/build/dist/stl_wrappers/string:44:
In file included from /usr/work/security/tor-browser/work/build/dist/system_wrappers/string:3:
In file included from /usr/include/c++/string:437:
In file included from /usr/work/security/tor-browser/work/build/dist/stl_wrappers/cstdio:44:
In file included from /usr/work/security/tor-browser/work/build/dist/system_wrappers/cstdio:3:
/usr/include/c++/cstdio:132:8: error: visibility does not match previous
      declaration
inline _LIBCPP_INLINE_VISIBILITY int feof(FILE* __stream) { return __lib...
       ^
/usr/include/c++/__config:220:51: note: expanded from macro
      '_LIBCPP_INLINE_VISIBILITY'
#define _LIBCPP_INLINE_VISIBILITY __attribute__ ((__visibility__("hidden...
                                                  ^
/usr/include/stdio.h:222:1: note: previous attribute is here
__BEGIN_DECLS
^
/usr/include/sys/cdefs.h:365:24: note: expanded from macro '__BEGIN_DECLS'
#define __BEGIN_DECLS           __BEGIN_PUBLIC_DECLS
                                ^
/usr/include/sys/cdefs.h:346:2: note: expanded from macro '__BEGIN_PUBLIC_DECLS'
        _Pragma("GCC visibility push(default)") __BEGIN_EXTERN_C
        ^
<scratch space>:212:6: note: expanded from here
 GCC visibility push(default)
     ^
2 errors generated.
gmake[3]: *** [/usr/work/security/tor-browser/work/firefox-tor-browser-60.8.0esr-8.5-1-build2/config/rules.mk:1056: hnjstdio.o] Error 1
gmake[3]: Leaving directory '/usr/work/security/tor-browser/work/build/intl/hyphenation/glue'
gmake[2]: *** [/usr/work/security/tor-browser/work/firefox-tor-browser-60.8.0esr-8.5-1-build2/config/recurse.mk:73: intl/hyphenation/glue/target] Error 2
gmake[2]: Leaving directory '/usr/work/security/tor-browser/work/build'
gmake[1]: *** [/usr/work/security/tor-browser/work/firefox-tor-browser-60.8.0esr-8.5-1-build2/config/recurse.mk:33: compile] Error 2
gmake[1]: Leaving directory '/usr/work/security/tor-browser/work/build'
gmake: *** [/usr/work/security/tor-browser/work/firefox-tor-browser-60.8.0esr-8.5-1-build2/config/rules.mk:442: all] Error 2
*** Error code 2

Stop.
make[1]: stopped in /usr/pkgsrc/security/tor-browser
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/security/tor-browser

>How-To-Repeat:

>Fix: