Re: pkg/54418: audio/alure bad header directory naming in PLIST under macos

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/54418; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54418: audio/alure bad header directory naming  in PLIST
 under macos
Date: Sun, 28 Jul 2019 19:12:00 +0000

 On Sun, Jul 28, 2019 at 03:35:00PM +0000, clement.bouvier.europe%gmail.com@localhost wrote:
  > +.include "../../mk/bsd.prefs.mk"
  > +
  > +PLIST_VARS+=    alincldir
  > +
  > +.if ${OPSYS} != "Darwin"
  > +PLIST.alincldir=	yes
  > +.endif
  > +
 
  > -include/AL/alure.h
  > +${PLIST.alincldir}include/AL/alure.h
 
 Better way to do this is:
 
  > +.include "../../mk/bsd.prefs.mk"
  > +
  > +PLIST_VARS+=    alincldir
  > +
  > +.if ${OPSYS} == "Darwin"
  > +PLIST.openalincldir=	yes
  > +.else
  > +PLIST.alincldir=		yes
  > +.endif
  > +
 
  > -include/AL/alure.h
  > +${PLIST.openalincldir}include/OpenAL/alure.h
  > +${PLIST.alincldir}include/AL/alure.h
 
 because in addition to being clearer to read it also continues to work
 if the conditional becomes more complicated.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost