pkg/54416: audio/libvisual failed to build on macos sched_setscheduler not defined.

[clement.bouvier.europe%gmail.com@localhost]

>Number:         54416
>Category:       pkg
>Synopsis:       audio/libvisual failed to build on macos sched_setscheduler not defined.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 28 08:05:00 +0000 2019
>Originator:     Clement Bouvier
>Release:        current
>Organization:
>Environment:
macos mojave 10.14.6
>Description:
audio/libvisual failed to build on macos with undefined symbol sched_setscheduler

libtool: link: clang -dynamiclib  -o .libs/libvisual-0.4.0.dylib  .libs/lv_actor.o .libs/lv_input.o .libs/lv_event.o .libs/lv_bin.o .libs/lv_plugin.o .libs/lv_video.o .libs/lv_video_simd.o .libs/lv_mem.o .libs/lv_audio.o .libs/lv_fourier.o .libs/lv_list.o .libs/lv_log.o .libs/lv_palette.o .libs/lv_libvisual.o .libs/lv_songinfo.o .libs/lv_morph.o .libs/lv_bmp.o .libs/lv_param.o .libs/lv_cpu.o .libs/lv_color.o .libs/lv_time.o .libs/lv_random.o .libs/lv_error.o .libs/lv_ui.o .libs/lv_thread.o .libs/lv_object.o .libs/lv_transform.o .libs/lv_rectangle.o .libs/lv_config.o .libs/lv_ringbuffer.o .libs/lv_buffer.o .libs/lv_cache.o .libs/lv_hashmap.o .libs/lv_hashlist.o .libs/lv_collection.o .libs/lv_utils.o .libs/lv_os.o .libs/lv_math.o .libs/lv_gl.o   -L/Users/cbouvier/prj/pkgsrc/audio/libvisual/work/.buildlink/lib -lm -ldl -L. /Users/cbouvier/prj/pkgsrc/audio/libvisual/work/.buildlink/lib/libintl.dylib -liconv -lc  -O2 -Wl,-rpath -Wl,/Users/cbouvier/pkg/lib   -install_name  /Users/cbouvier/
 pkg/lib/libvisual-0.4.0.dylib -compatibility_version 1 -current_version 1.0 -Wl,-single_module
Undefined symbols for architecture x86_64:
  "_sched_setscheduler", referenced from:
      _visual_os_scheduler_realtime_start in lv_os.o
      _visual_os_scheduler_realtime_stop in lv_os.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error code 1


>How-To-Repeat:
build audio/libvisual on macosx.
>Fix:
macos ox has header sched.h but does not provide the realtime function:

int sched_setscheduler(pid_t, int, const struct sched_param *);
(optional according to open group).

so it is necessary to force real time defined functions in the package are not supported on apple system.

patch:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/audio/libvisual/Makefile,v
retrieving revision 1.27
diff -u -r1.27 Makefile
--- Makefile    4 Jul 2018 13:40:08 -0000       1.27
+++ Makefile    28 Jul 2019 07:58:17 -0000
@@ -2,7 +2,7 @@
 #
 
 DISTNAME=      libvisual-0.4.0
-PKGREVISION=   4
+PKGREVISION=   5
 CATEGORIES=    audio graphics
 MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=libvisual/}
 
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/audio/libvisual/distinfo,v
retrieving revision 1.14
diff -u -r1.14 distinfo
--- distinfo    3 Nov 2015 01:12:39 -0000       1.14
+++ distinfo    28 Jul 2019 07:58:17 -0000
@@ -9,4 +9,5 @@
 SHA1 (patch-ad) = e7b2493cf5880cea7497a1d8d6fb1ce4f856ba6d
 SHA1 (patch-ae) = 72affdd9a1302a16efe5f4ecaafbc37061e4db0c
 SHA1 (patch-libvisual_lv__defines.h) = 9b14140411ae426226318a0ccdbe64d905b7710c
+SHA1 (patch-libvisual_lv__os.c) = 66d812548e081d11ad874d5c57f84656e70a855f
 SHA1 (patch-libvisual_lv__types.h) = 3f2baa4861b50d3359cd9cdfa75898dfc6b5895d
Index: patches/patch-libvisual_lv__os.c
===================================================================
RCS file: patches/patch-libvisual_lv__os.c
diff -N patches/patch-libvisual_lv__os.c
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ patches/patch-libvisual_lv__os.c    28 Jul 2019 07:58:17 -0000
@@ -0,0 +1,14 @@
+$NetBSD$
+
+--- libvisual/lv_os.c.orig     2006-01-26 15:13:37.000000000 +0000
++++ libvisual/lv_os.c
+@@ -31,7 +31,9 @@
+ #ifdef HAVE_SCHED_H
+ # include <sched.h>
+ # include <sys/types.h>
++#ifndef __APPLE__
+ # define HAVE_SCHED 1
++#endif
+ #elif defined HAVE_SYS_SCHED_H
+ # include <sys/sched.h>
+ # include <sys/types.h>