pkg/54354: archivers/gcpio failed to install on macosx

[clement.bouvier.europe%gmail.com@localhost]

>Number:         54354
>Category:       pkg
>Synopsis:       archivers/gcpio failed to install on macosx
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 07 04:55:00 +0000 2019
>Originator:     clément bouvier
>Release:        current
>Organization:
>Environment:
macosx mojave 10.14.5
>Description:
archivers/gcpio does not install on macosx with following errors:

ERROR: The following files are in the PLIST but not in .desdir
ERROR: [...]/libexec/grmt
ERROR: [...]/man/man8/grmt.8
>How-To-Repeat:
install archivers/gcpio
>Fix:
PLIST.rmt was defined but not used in the PLIST file, so let's use it.

(also the patch removes a redundant .include bsd.prefs.mk already include early in the Makefile)

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/archivers/gcpio/Makefile,v
retrieving revision 1.51
diff -u -r1.51 Makefile
--- Makefile	18 Sep 2016 11:20:14 -0000	1.51
+++ Makefile	7 Jul 2019 04:42:12 -0000
@@ -32,11 +32,11 @@
 .include "../../mk/bsd.prefs.mk"
 
 # don't include rmt if gtar won't build it
+# macos does not support rmt driver, so it won't be built
 .if ${OPSYS} != "Interix" && ${OPSYS} != "Darwin"
 PLIST.rmt=	yes
 .endif
 
-.include "../../mk/bsd.prefs.mk"
 
 post-install:
 	${LN} -sf ${PREFIX}/bin/gcpio ${DESTDIR}${PREFIX}/${PKGGNUDIR}bin/cpio
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/archivers/gcpio/PLIST,v
retrieving revision 1.16
diff -u -r1.16 PLIST
--- PLIST	18 Sep 2016 11:20:14 -0000	1.16
+++ PLIST	7 Jul 2019 04:42:12 -0000
@@ -4,9 +4,9 @@
 gnu/man/man1/cpio.1
 gnu/man/man1/mt.1
 info/cpio.info
-libexec/grmt
+${PLIST.rmt}libexec/grmt
 man/man1/gcpio.1
-man/man8/grmt.8
+${PLIST.rmt}man/man8/grmt.8
 share/locale/da/LC_MESSAGES/cpio.mo
 share/locale/de/LC_MESSAGES/cpio.mo
 share/locale/es/LC_MESSAGES/cpio.mo