pkg/54165: pkgsrc/devel/SDL2 should not use rpi option for all arm

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         54165
>Category:       pkg
>Synopsis:       pkgsrc/devel/SDL2 should not use rpi option for all arm
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 06 05:15:00 +0000 2019
>Originator:     Izumi Tsutsui
>Release:        NetBSD/hpcarm 8.0 + pkgsrc-2019Q1
>Organization:
>Environment:
System: 
NetBSD wzero3 8.0 NetBSD 8.0 (WZERO3) #0: Tue Jul 17 14:59:51 UTC 2018  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/hpcarm/compile/WZERO3 hpcarm
Architecture: earmv4
Machine: hpcarm
>Description:
pkgsrc/devel/SDL2/options.mk choose 'rpi' option
if MACHINE_ARCH includes 'arm' strings:
---
.if !empty(MACHINE_ARCH:M*arm*)
PKG_OPTIONS_GROUP.gl+= rpi
PKG_SUGGESTED_OPTIONS+= rpi
.else
PKG_SUGGESTED_OPTIONS+= opengl
.endif
---

But it causes SIGILL on running SDL2 applications
on hpcarm WS003SH (armv5 XScale PXA270):

---
wzero3-% PC6001VX
Illegal instruction (core dumped)
wzero3-% gdb PC6001VX

 :

Program received signal SIGILL, Illegal instruction.
0xb8e48774 in vcos_log_register (name=0xb8e4b194 "default",
category=0xb8e5e954 <dflt_log_category>)
at /usr/obj.earmv4/pkgsrc/misc/raspberrypi-userland/work.earmv4/userland-734d76b0675685e9ec9148694f2cc00f58e5ebc0/interface/vcos/generic/vcos_logcat.c:378
 :

---

>How-To-Repeat:
Build and exec PC6001VX (and other packages that use SDL2) on hpcarm
or other armv[45] machines.

>Fix:
Enable it only on armv[678]?
---
===================================================================
RCS file: /cvsroot/pkgsrc/devel/SDL2/options.mk,v
retrieving revision 1.10
diff -u -p -d -r1.10 options.mk
--- options.mk  24 Dec 2018 16:25:30 -0000      1.10
+++ options.mk  6 May 2019 05:08:21 -0000
@@ -12,7 +12,7 @@ PKG_SUGGESTED_OPTIONS+=       x11
 
 .include "../../mk/bsd.fast.prefs.mk"
 
-.if !empty(MACHINE_ARCH:M*arm*)
+.if !empty(MACHINE_ARCH:M*armv[678]*)
 PKG_OPTIONS_GROUP.gl+= rpi
 PKG_SUGGESTED_OPTIONS+=        rpi
 .else
---

Or make it actually optional?
(no way to switch runtime with both options?)

---
Izumi Tsutsui