Re: pkg/54144 (SUBST stage fix from post-patch to pre-configure breaks build)

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/54144; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54144 (SUBST stage fix from post-patch to pre-configure breaks build)
Date: Sun, 28 Apr 2019 17:21:53 +0200

 Hello Makoto, 
 
 Makoto Fujiwara writes:
 >  [...]
 >  If the package is set as
 >     NO_CONFIGURE=   yes,
 >  pre-configure stage won't run.
 >  
 >  That's why SUBST won't be applied.
 >  [...]
 
 That's right.  Most of the times (like here) NO_CONFIGURE=yes is
 actually not needed, lead to surprising results and can be just
 removed (package that has a configure defines HAS_CONFIGURE=yes or
 GNU_CONFIGURE=yes).
 
 Just removing the `NO_CONFIGURE= yes' line should be enough to fix
 this problem.  Feel free to commit that if that works!
 
 
 Thanks!