pkg/54072: x11/qt5-qtbase broken on Linux: assumes tslib and libdrm, PLIST failure

[thomas.orgs%uni-hamburg.de@localhost]

>Number:         54072
>Category:       pkg
>Synopsis:       x11/qt5-qtbase broken on Linux: assumes tslib and libdrm, PLIST  failure
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 25 16:05:00 +0000 2019
>Originator:     Dr. Thomas Orgis
>Release:        CVS trunk 20190321
>Organization:
Universität Hamburg / RRZ
>Environment:
Linux x86-64
>Description:
Hi,

I tried building qt5-qtbase from CVS and it failed because file
relating to libdrm and tslib are missing. I added

CONFIGURE_ARGS+=        -kms
CONFIGURE_ARGS+=        -tslib
.include                "../../x11/libdrm/buildlink3.mk"
.include                "../../wip/tslib/buildlink3.mk"

to fix this (the configure arguments to ensure early failure before
building). The change

https://github.com/NetBSD/pkgsrc/commit/20aa53ee4b4c2ce12f8ad27971f9508cb81a3f56

broke the build (or at least didn't fix it) for systems that don't
offer tslib. I am not sure about libdrm, it is present, but the build
was not able to pick it up. The explicit dependency should be used,
anyway.

Please also note the related report 53310 about integrating tslib.
There is a more proper approach with options (I was not aware of
-no-tslib working, may check some time when not under time pressure).

I hope we can get this fixed before 2019Q1 release. Broken Qt5 on Linux
is a bit embarrassing.
>How-To-Repeat:
Try to build qt5-qtbase on a Linux system without having build libdrm or tslib.
>Fix:
Workaround:

CONFIGURE_ARGS+=        -kms
CONFIGURE_ARGS+=        -tslib
.include                "../../x11/libdrm/buildlink3.mk"
.include                "../../wip/tslib/buildlink3.mk"