pkg/54054: Package lang/go112 does not build on CentOS 7 (missing PLIST.route in PLIST)

[dave%weller-fahy.com@localhost]

>Number:         54054
>Category:       pkg
>Synopsis:       Package lang/go112 does not build on CentOS 7 (missing PLIST.route in PLIST)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 11 13:05:00 +0000 2019
>Originator:     David J. Weller-Fahy
>Release:        pkgsrc current as of 2019-03-11
>Organization:
>Environment:
Linux pooh 3.10.0-957.5.1.el7.x86_64 #1 SMP Fri Feb 1 14:54:57 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
>Description:
Package lang/go112 does not build on CentOS 7 because of a missing ${PLIST.route} in the PLIST file. The PLIST file in lang/go111 contains the ${PLIST.route}.

The resulting error follows:

#v+
=> Checking file-check results for go112-1.12
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /home/dave/pkg-centos-7/usr/work/lang/go112/work/.destdir/home/dave/pkg-centos-7:
ERROR:         /home/dave/pkg-centos-7/usr/work/lang/go112/work/.destdir/home/dave/pkg-centos-7/go112/pkg/linux_amd64/internal/x/net/route.a
*** Error code 1

Stop.
bmake[4]: stopped in /home/dave/usr/src/pkgsrc/lang/go112
*** Error code 1

Stop.
bmake[3]: stopped in /home/dave/usr/src/pkgsrc/lang/go112
*** Error code 1

Stop.
bmake[2]: stopped in /home/dave/usr/src/pkgsrc/lang/go112
*** Error code 1

Stop.
bmake[1]: stopped in /home/dave/usr/src/pkgsrc/devel/git-lfs
*** Error code 1

Stop.
bmake: stopped in /home/dave/usr/src/pkgsrc/devel/git-lfs
** 'cd /home/dave/usr/src/pkgsrc/devel/git-lfs && /home/dave/pkg-centos-7/bin/bmake update CLEANDEPENDS=yes' failed
** ** 'cd /home/dave/usr/src/pkgsrc/devel/git-lfs && /home/dave/pkg-centos-7/bin/bmake update CLEANDEPENDS=yes' failed
#v-
>How-To-Repeat:
Try to install go112.
>Fix:
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/lang/go112/PLIST,v
retrieving revision 1.1
diff -u -p -r1.1 PLIST
--- PLIST	9 Mar 2019 09:29:30 -0000	1.1
+++ PLIST	11 Mar 2019 13:02:04 -0000
@@ -1510,7 +1510,7 @@ go112/pkg/${GO_PLATFORM}/internal/x/net/
 go112/pkg/${GO_PLATFORM}/internal/x/net/idna.a
 go112/pkg/${GO_PLATFORM}/internal/x/net/internal/nettest.a
 go112/pkg/${GO_PLATFORM}/internal/x/net/nettest.a
-go112/pkg/${GO_PLATFORM}/internal/x/net/route.a
+${PLIST.route}go112/pkg/${GO_PLATFORM}/internal/x/net/route.a
 go112/pkg/${GO_PLATFORM}/internal/x/text/secure.a
 go112/pkg/${GO_PLATFORM}/internal/x/text/secure/bidirule.a
 go112/pkg/${GO_PLATFORM}/internal/x/text/transform.a