pkg/53971: Circular dependency with ncurses on FreeBSD 12

[triaxx%NetBSD.org@localhost]

>Number:         53971
>Category:       pkg
>Synopsis:       Circular dependency with ncurses on FreeBSD 12
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 12 20:00:00 +0000 2019
>Originator:     Frédéric Fauberteau
>Release:        FreeBSD 12.0-RELEASE-p3
>Organization:
	
>Environment:
System: FreeBSD cocoon.triaxx.org 12.0-RELEASE-p3 FreeBSD 12.0-RELEASE-p3 GENERIC  amd64
Architecture: x86_64
Machine: amd64
Pkgsrc branch: pkgsrc-2018Q4
>Description:
A circular dependency occurs when trying to build a package that depends on devel/ncurses. Since groff is no more available in basesystem, pkgsrc tries to build it and loops on devel/ncurses...
devel/ncurses/Makefile.common provides a comment about this problem.
>How-To-Repeat:
For instance:
cd /usr/pkgsrc/misc/tmux && bmake package install
>Fix:
Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/devel/ncurses/Makefile.common,v
retrieving revision 1.37
diff -u -r1.37 Makefile.common
--- Makefile.common	15 Sep 2018 22:47:41 -0000	1.37
+++ Makefile.common	12 Feb 2019 19:52:10 -0000
@@ -54,7 +54,8 @@
 # otherwise we get a circular dependency problem.
 # Additionally, Interix is special, see ../../mk/curses.buildlink3.mk
 .  if !(exists(/usr/include/curses.h) || exists(/usr/include/ncurses.h)) || \
-	${OPSYS} == "Interix"
+	${OPSYS} == "Interix" || \
+	(${OPSYS} == "FreeBSD" && ${OS_VERSION} >= 12)
 # None was available, so disable use of tbl(1)
 USE_TOOLS:=		${USE_TOOLS:Ntbl}
 CONFIGURE_ARGS+=	--without-manpage-tbl