Re: pkg/53396: xfwm4 crashes

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/53396; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: martin%NetBSD.org@localhost
Subject: Re: pkg/53396: xfwm4 crashes
Date: Fri, 25 Jan 2019 16:20:53 +0000

 On Tue, Jun 26, 2018 at 06:50:01AM +0000, Martin Husemann wrote:
  >  Obvious bug, sn_startup_sequence_get_last_active_time takes two
  >  long pointer arguments, but xfc4-wm passes pointers to
  >  may-be-different types.
  >  
  >  The patch below should fix it.
  >     :
  >       time_t tv_sec;
  >       suseconds_t tv_usec;
  >  +    long l_sec, l_usec;
  >       double elapsed;
  >     :
  >  -    sn_startup_sequence_get_last_active_time (sequence, &tv_sec, &tv_usec);
  >  +    sn_startup_sequence_get_last_active_time (sequence, &l_sec, &l_usec);
  >  +    tv_sec = l_sec; tv_usec = l_sec;
 
 two questions:
 
 (1) Shouldn't it have not built without this change?
 (2) Isn't truncating time_t to long a bug? (That is, shouldn't
     sn_startup_sequence_get_last_active_time be changed to take the
     right types, at least for upstream?)
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost