Re: pkg/53771: digest keccak.c does not compile on IRIX with mipspro compiler

[Alistair Crooks <agc%pkgsrc.org@localhost>]

The following reply was made to PR pkg/53771; it has been noted by GNATS.

From: Alistair Crooks <agc%pkgsrc.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/53771: digest keccak.c does not compile on IRIX with mipspro compiler
Date: Mon, 10 Dec 2018 13:01:02 -0800

 --000000000000e7f0f8057cb14309
 Content-Type: text/plain; charset="UTF-8"
 
 Can you try to run the self tests, please? (They're for SHA3, so quote
 relevant): "digest -t"
 
 Thanks,
 Alistair
 
 On Sun, 9 Dec 2018 at 22:57, <esp%iki.fi@localhost> wrote:
 
 > >Number:         53771
 > >Category:       pkg
 > >Synopsis:       digest keccak.c does not compile on IRIX with mipspro
 > compiler
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       medium
 > >Responsible:    pkg-manager
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Mon Dec 10 06:45:00 +0000 2018
 > >Originator:     Erno Palonheimo
 > >Release:        current-20181201
 > >Organization:
 > >Environment:
 > IRIX64 arpakuutio 6.5 07202013 IP30 mips
 >
 > >Description:
 > keccak.c of digest package has this preprocessor macro:
 >
 > #define FOR5(X, STMT) do
 >     \
 > {
 >    \
 >         (X) = 0; (STMT);
 >     \
 >         (X) = 1; (STMT);
 >     \
 >         (X) = 2; (STMT);
 >     \
 >         (X) = 3; (STMT);
 >     \
 >         (X) = 4; (STMT);
 >     \
 > } while (0)
 >
 > It results in code that has a gcc-specific syntax and Mipspro won't
 > compile it.
 > >How-To-Repeat:
 > Try to build digest on IRIX using Mipspro.
 > >Fix:
 > Discussion on Freenode #pkgsrc revealed that this could possibly be worked
 > around by changing the (STMT) on the macro to {STMT} as suggested by
 > Rhialto. I changed the file manually and at least the compiler compiled it
 > and the digest command works now. If further help in testing this on IRIX
 > is needed, I can run tests on the machine.
 >
 >
 
 --000000000000e7f0f8057cb14309
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: base64
 
 PGRpdiBkaXI9Imx0ciI+Q2FuIHlvdSB0cnkgdG8gcnVuIHRoZSBzZWxmIHRlc3RzLCBwbGVhc2U/
 IChUaGV5JiMzOTtyZSBmb3IgU0hBMywgc28gcXVvdGUgcmVsZXZhbnQpOiAmcXVvdDtkaWdlc3Qg
 LXQmcXVvdDs8ZGl2Pjxicj48L2Rpdj48ZGl2PlRoYW5rcyw8L2Rpdj48ZGl2PkFsaXN0YWlyPC9k
 aXY+PC9kaXY+PGJyPjxkaXYgY2xhc3M9ImdtYWlsX3F1b3RlIj48ZGl2IGRpcj0ibHRyIj5PbiBT
 dW4sIDkgRGVjIDIwMTggYXQgMjI6NTcsICZsdDs8YSBocmVmPSJtYWlsdG86ZXNwQGlraS5maSI+
 ZXNwQGlraS5maTwvYT4mZ3Q7IHdyb3RlOjxicj48L2Rpdj48YmxvY2txdW90ZSBjbGFzcz0iZ21h
 aWxfcXVvdGUiIHN0eWxlPSJtYXJnaW46MCAwIDAgLjhleDtib3JkZXItbGVmdDoxcHggI2NjYyBz
 b2xpZDtwYWRkaW5nLWxlZnQ6MWV4Ij4mZ3Q7TnVtYmVyOsKgIMKgIMKgIMKgIMKgNTM3NzE8YnI+
 DQomZ3Q7Q2F0ZWdvcnk6wqAgwqAgwqAgwqBwa2c8YnI+DQomZ3Q7U3lub3BzaXM6wqAgwqAgwqAg
 wqBkaWdlc3Qga2VjY2FrLmMgZG9lcyBub3QgY29tcGlsZSBvbiBJUklYIHdpdGggbWlwc3BybyBj
 b21waWxlcjxicj4NCiZndDtDb25maWRlbnRpYWw6wqAgwqBubzxicj4NCiZndDtTZXZlcml0eTrC
 oCDCoCDCoCDCoG5vbi1jcml0aWNhbDxicj4NCiZndDtQcmlvcml0eTrCoCDCoCDCoCDCoG1lZGl1
 bTxicj4NCiZndDtSZXNwb25zaWJsZTrCoCDCoCBwa2ctbWFuYWdlcjxicj4NCiZndDtTdGF0ZTrC
 oCDCoCDCoCDCoCDCoCBvcGVuPGJyPg0KJmd0O0NsYXNzOsKgIMKgIMKgIMKgIMKgIHN3LWJ1Zzxi
 cj4NCiZndDtTdWJtaXR0ZXItSWQ6wqAgwqBuZXQ8YnI+DQomZ3Q7QXJyaXZhbC1EYXRlOsKgIMKg
 TW9uIERlYyAxMCAwNjo0NTowMCArMDAwMCAyMDE4PGJyPg0KJmd0O09yaWdpbmF0b3I6wqAgwqAg
 wqBFcm5vIFBhbG9uaGVpbW88YnI+DQomZ3Q7UmVsZWFzZTrCoCDCoCDCoCDCoCBjdXJyZW50LTIw
 MTgxMjAxPGJyPg0KJmd0O09yZ2FuaXphdGlvbjo8YnI+DQomZ3Q7RW52aXJvbm1lbnQ6PGJyPg0K
 SVJJWDY0IGFycGFrdXV0aW8gNi41IDA3MjAyMDEzIElQMzAgbWlwczxicj4NCjxicj4NCiZndDtE
 ZXNjcmlwdGlvbjo8YnI+DQprZWNjYWsuYyBvZiBkaWdlc3QgcGFja2FnZSBoYXMgdGhpcyBwcmVw
 cm9jZXNzb3IgbWFjcm86PGJyPg0KPGJyPg0KI2RlZmluZSBGT1I1KFgsIFNUTVQpIGRvwqAgwqAg
 wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
 wqAgwqAgwqAgwqAgwqAgwqAgXDxicj4NCnvCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
 oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
 oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoFw8YnI+DQrCoCDCoCDCoCDCoCAoWCkgPSAwOyAo
 U1RNVCk7wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
 wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgXDxicj4NCsKgIMKgIMKgIMKgIChYKSA9IDE7
 IChTVE1UKTvCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
 oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBcPGJyPg0KwqAgwqAgwqAgwqAgKFgpID0g
 MjsgKFNUTVQpO8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
 IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIFw8YnI+DQrCoCDCoCDCoCDCoCAoWCkg
 PSAzOyAoU1RNVCk7wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
 wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgXDxicj4NCsKgIMKgIMKgIMKgIChY
 KSA9IDQ7IChTVE1UKTvCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
 oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBcPGJyPg0KfSB3aGlsZSAoMCk8
 YnI+DQo8YnI+DQpJdCByZXN1bHRzIGluIGNvZGUgdGhhdCBoYXMgYSBnY2Mtc3BlY2lmaWMgc3lu
 dGF4IGFuZCBNaXBzcHJvIHdvbiYjMzk7dCBjb21waWxlIGl0Ljxicj4NCiZndDtIb3ctVG8tUmVw
 ZWF0Ojxicj4NClRyeSB0byBidWlsZCBkaWdlc3Qgb24gSVJJWCB1c2luZyBNaXBzcHJvLjxicj4N
 CiZndDtGaXg6PGJyPg0KRGlzY3Vzc2lvbiBvbiBGcmVlbm9kZSAjcGtnc3JjIHJldmVhbGVkIHRo
 YXQgdGhpcyBjb3VsZCBwb3NzaWJseSBiZSB3b3JrZWQgYXJvdW5kIGJ5IGNoYW5naW5nIHRoZSAo
 U1RNVCkgb24gdGhlIG1hY3JvIHRvIHtTVE1UfSBhcyBzdWdnZXN0ZWQgYnkgUmhpYWx0by4gSSBj
 aGFuZ2VkIHRoZSBmaWxlIG1hbnVhbGx5IGFuZCBhdCBsZWFzdCB0aGUgY29tcGlsZXIgY29tcGls
 ZWQgaXQgYW5kIHRoZSBkaWdlc3QgY29tbWFuZCB3b3JrcyBub3cuIElmIGZ1cnRoZXIgaGVscCBp
 biB0ZXN0aW5nIHRoaXMgb24gSVJJWCBpcyBuZWVkZWQsIEkgY2FuIHJ1biB0ZXN0cyBvbiB0aGUg
 bWFjaGluZS48YnI+DQo8YnI+DQo8L2Jsb2NrcXVvdGU+PC9kaXY+DQo=
 --000000000000e7f0f8057cb14309--