pkg/53745: pkgsrc/misc/raspberrypi-userland fails with PKG_DEVELOPER=yes

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         53745
>Category:       pkg
>Synopsis:       pkgsrc/misc/raspberrypi-userland fails with PKG_DEVELOPER=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 26 14:35:00 +0000 2018
>Originator:     Izumi Tsutsui
>Release:        NetBSD 8.0
>Organization:
>Environment:
System: NetBSD rpi3 8.0 NetBSD 8.0 (RPI2) #0: Tue Jul 17 14:59:51 UTC 2018  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/evbarm/compile/RPI2 evbarm
Architecture: earmv6hf
Machine: evbarm RPI3B
>Description:
pkgsrc-2018Q3 pkgsrc/misc/raspberrypi-userland fails on make package
with PKG_DEVELOPER=yes:

---
 :
=> Automatic manual page handling
=> Generating post-install file lists
=> Checking file-check results for raspberrypi-userland-20170109nb1
=> Checking for non-existent script interpreters in raspberrypi-userland-20170109nb1
ERROR: [check-interpreter.mk] The interpreter "/bin/bash" of "/usr/obj.earmv6hf/pkgsrc/misc/raspberrypi-userland/work.earmv6hf/.destdir/usr/pkg/bin/dtoverlay-post" does not exist.
ERROR: [check-interpreter.mk] The interpreter "/bin/bash" of "/usr/obj.earmv6hf/pkgsrc/misc/raspberrypi-userland/work.earmv6hf/.destdir/usr/pkg/bin/dtoverlay-pre" does not exist.
*** Error code 1

Stop.
make[1]: stopped in /usr/pkgsrc/misc/raspberrypi-userland
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/misc/raspberrypi-userland

---

>How-To-Repeat:
% cd pkgsrc/misc/raspberrypi-userland
% env PKG_DEVELOPER=yes make package

>Fix:
Replace the paths using SUBST? or disable check-interpreter?

--- Makefile	2018-11-26 14:11:32.557535021 +0000
+++ Makefile.1	2018-11-26 14:24:59.971424021 +0000
@@ -29,6 +29,14 @@
 SUBST_FILES.vc=		makefiles/cmake/vmcs.cmake
 SUBST_SED.vc=		-e 's,/opt/vc,${PREFIX},g'
 
+SUBST_CLASSES+=		bash
+SUBST_STAGE.bash=	pre-configure
+SUBST_MESSAGE.bash=	Fixing hard-coded /bin/bash paths.
+SUBST_FILES.bash=	buildme	\
+			host_applications/linux/apps/dtoverlay/dtoverlay-post \
+			host_applications/linux/apps/dtoverlay/dtoverlay-pre
+SUBST_SED.bash=		-e 's,/bin/bash,${PREFIX}/bin/bash,g'
+
 .include "options.mk"
 
 .include "../../mk/bsd.pkg.mk"