pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/53731: Missing dependency and wrong PLIST for chat/gajim



>Number:         53731
>Category:       pkg
>Synopsis:       Missing dependency and wrong PLIST for chat/gajim
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 18 16:50:00 +0000 2018
>Originator:     Jonathan Schleifer
>Release:        HEAD
>Organization:
>Environment:
macOS Mojave
>Description:
chat/gajim needs security/py-certifi, but the dependency is not declared in the Makefile.
Additionally, the PLIST is incorrect (at least on macOS - I have not verified on anything else).

Proposed fix attached.
>How-To-Repeat:
Build chat/gajim (on macOS)
>Fix:
commit 9cfd49361243ea123d23cf38bc601f0330f92db5
Author: Jonathan Schleifer <js%heap.zone@localhost>
Date:   Sun Nov 18 17:46:08 2018 +0100

    chat/gajim: Fix PLIST and missing dependency

diff --git a/chat/gajim/Makefile b/chat/gajim/Makefile
index 2522a357ea6..1fab37c9f32 100644
--- a/chat/gajim/Makefile
+++ b/chat/gajim/Makefile
@@ -1,6 +1,7 @@
 # $NetBSD: Makefile,v 1.44 2018/11/16 00:00:02 nia Exp $
 
 DISTNAME=	gajim-1.1.0
+PKGREVISION=	1
 CATEGORIES=	chat python
 MASTER_SITES=	https://www.gajim.org/downloads/1.1/
 
@@ -19,6 +20,7 @@ _TOOLS_USE_PKGSRC.msgfmt=	yes
 
 PYTHON_VERSIONS_INCOMPATIBLE=	27
 
+DEPENDS+=	${PYPKGPREFIX}-certifi-[0-9]*:../../security/py-certifi
 DEPENDS+=	${PYPKGPREFIX}-cssutils-[0-9]*:../../textproc/py-cssutils
 DEPENDS+=	${PYPKGPREFIX}-gobject3-[0-9]*:../../devel/py-gobject3
 DEPENDS+=	${PYPKGPREFIX}-keyring-[0-9]*:../../security/py-keyring
diff --git a/chat/gajim/PLIST b/chat/gajim/PLIST
index fbe96e604a5..c1af9e78fad 100644
--- a/chat/gajim/PLIST
+++ b/chat/gajim/PLIST
@@ -1,13 +1,13 @@
-@comment $NetBSD: PLIST,v 1.4 2018/11/16 00:00:02 nia Exp $
+@comment $NetBSD$
 bin/gajim
 bin/gajim-history-manager
 bin/gajim-remote
-${PYSITELIB}/${EGG_INFODIR}/PKG-INFO
-${PYSITELIB}/${EGG_INFODIR}/SOURCES.txt
-${PYSITELIB}/${EGG_INFODIR}/dependency_links.txt
-${PYSITELIB}/${EGG_INFODIR}/entry_points.txt
-${PYSITELIB}/${EGG_INFODIR}/requires.txt
-${PYSITELIB}/${EGG_INFODIR}/top_level.txt
+${PYSITELIB}/${PKGNAME}+5b86a4f31b81-py${PYVERSSUFFIX}.egg-info/PKG-INFO
+${PYSITELIB}/${PKGNAME}+5b86a4f31b81-py${PYVERSSUFFIX}.egg-info/SOURCES.txt
+${PYSITELIB}/${PKGNAME}+5b86a4f31b81-py${PYVERSSUFFIX}.egg-info/dependency_links.txt
+${PYSITELIB}/${PKGNAME}+5b86a4f31b81-py${PYVERSSUFFIX}.egg-info/entry_points.txt
+${PYSITELIB}/${PKGNAME}+5b86a4f31b81-py${PYVERSSUFFIX}.egg-info/requires.txt
+${PYSITELIB}/${PKGNAME}+5b86a4f31b81-py${PYVERSSUFFIX}.egg-info/top_level.txt
 ${PYSITELIB}/gajim/__init__.py
 ${PYSITELIB}/gajim/__init__.pyo
 ${PYSITELIB}/gajim/__init__.pyc



Home | Main Index | Thread Index | Old Index