pkg/53706: wm/blackbox70 fails to build on NetBSD 8.0_STABLE

[david%gutteridge.ca@localhost]

>Number:         53706
>Category:       pkg
>Synopsis:       wm/blackbox70 fails to build on NetBSD 8.0_STABLE
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 07 06:25:00 +0000 2018
>Originator:     David H. Gutteridge
>Release:        pkgsrc HEAD
>Organization:
>Environment:
>Description:
When trying to build wm/blackbox70 on NetBSD 8.0_STABLE, I've found it
fails during the "make package" phase, with:

=> Generating post-install file lists
=> Checking file-check results for blackbox70-0.72
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg:
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/da/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/de/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/en@boldquot/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/en@quot/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/es/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/es_AR/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/et/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/fr/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/hu/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/it/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/ja/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/ko/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/lv/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/nl/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/no/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/pl/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/pt_BR/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/ro/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/ru/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/sk/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/sl/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/sv/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/tr/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/uk/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/zh_CN/LC_MESSAGES/blackbox.mo
ERROR:         /usr/pkgsrc/wm/blackbox70/work/.destdir/usr/pkg/share/locale/zh_TW/LC_MESSAGES/blackbox.mo
*** Error code 1

In revision 1.16 of Makefile, this was added:

CONFIGURE_ARGS+=        --enable-nls

However, it doesn't actually work as-is, at least on NetBSD:

checking whether NLS is requested... yes
checking for msgfmt... /usr/pkgsrc/wm/blackbox70/work/.tools/bin/msgfmt
checking for gmsgfmt... /usr/pkgsrc/wm/blackbox70/work/.tools/bin/msgfmt
checking for xgettext... /usr/pkg/bin/xgettext
checking for msgmerge... /usr/pkg/bin/msgmerge
checking for ld used by gcc... /usr/pkgsrc/wm/blackbox70/work/.cwrapper/bin/ld
checking if the linker (/usr/pkgsrc/wm/blackbox70/work/.cwrapper/bin/ld) is GNU ld... yes
checking for shared library run path origin... done
checking for CFPreferencesCopyAppValue... no
checking for CFLocaleCopyCurrent... no
checking for GNU gettext in libc... no
checking for iconv... yes
checking for working iconv... yes
checking for GNU gettext in libintl... no
checking whether to use NLS... no

(Please see fix commentary below.)

>How-To-Repeat:
Try building the package.
>Fix:
The following patch allows it to complete "make package" successfully.

--- Makefile.orig       2018-10-29 23:26:40.636076886 -0400
+++ Makefile    2018-11-07 00:57:30.802797411 -0500
@@ -22,14 +22,14 @@
 
 CONFIGURE_ARGS+=       --enable-nls
 
-LIBS+=         ${BUILDLINK_LDADD.iconv}
+LIBS+=         ${BUILDLINK_LDADD.gettext}
 
 BUILDLINK_DEPMETHOD.libXt?=    build
 
 pre-configure:
        cd ${WRKSRC}; ${SH} ./autogen.sh
 
-.include "../../converters/libiconv/buildlink3.mk"
+.include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../x11/libX11/buildlink3.mk"
 .include "../../x11/libXt/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"

(The buildlink3.mk file of devel/gettext-lib already has:

.include "../../converters/libiconv/buildlink3.mk"

and

BUILDLINK_LDADD.gettext+=	${BUILDLINK_LDADD.iconv}

so in my understanding neither reference would need to be explicitly
provided in blackbox70's Makefile anymore.)