Re: pkg/53686: shells/pdksh building fails due to wrong preprocessor checking

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

The following reply was made to PR pkg/53686; it has been noted by GNATS.

From: "David H. Gutteridge" <david%gutteridge.ca@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/53686: shells/pdksh building fails due to wrong
 preprocessor checking
Date: Sat, 27 Oct 2018 16:37:26 -0400

 Questions and comments (and apologies if this is out of sync with
 what's running through Gnats, and someone else has already replied
 with these):
 
 Are you building this as a result of bootstrapping pkgsrc (i.e.,
 using a "full" bootstrap, since the default bootstrap for Linux
 doesn't pull in pdksh, from what I can see)? Or are you building this
 for your own use? If the latter, have you considered mksh instead? I
 would strongly recommend using it over pdksh, if you simply want a ksh
 implementation. mksh is more actively maintained, and is my go-to on
 Linux.
 
 My understanding is that Arch Linux defines _FORTIFY_SOURCE in
 makepkg.conf[1]. Is this file being pulled in somehow (i.e., you're
 doing a "full" bootstrap, and so compiling using the native Arch
 environment)?
 
 Note that the configure script for the pdksh package was generated
 using autoconf 2.12, so you're relying upon output from a tool from
 1996 that may not interact well with more current environments.
 
 The Internet is scattered with references to this very issue on Arch.
 A useful report is one for GRASS[2], which summarizes this problem
 well. Comment #7 explains the pattern of errors you're seeing: "This
 all arises because autoconf tends to treat ANYTHING written to stderr
 as indicating a failure." (Comments #7 and #12 are detailed about
 this.)
 
 As a local workaround, you could also append your own redefinition of
 _FORTIFY_SOURCE to CPPFLAGS, either with -U or with -D setting the
 value to zero.
 
 [1] 
 https://lists.archlinux.org/pipermail/arch-dev-public/2013-April/024776.html
 [2] https://trac.osgeo.org/grass/ticket/2916
 
 Dave