Re: pkg/53686: shells/pdksh building fails due to wrong preprocessor checking

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

The following reply was made to PR pkg/53686; it has been noted by GNATS.

From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Fauberteau?= <triaxx%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/53686: shells/pdksh building fails due to wrong preprocessor  checking
Date: Sat, 27 Oct 2018 16:26:25 +0200

 Le 2018-10-27 08:00, coypu%sdf.org@localhost a écrit :
 > The following reply was made to PR pkg/53686; it has been noted by 
 > GNATS.
 > 
 > From: coypu%sdf.org@localhost
 > To: gnats-bugs%netbsd.org@localhost
 > Cc:
 > Subject: Re: pkg/53686: shells/pdksh building fails due to wrong 
 > preprocessor
 >  checking
 > Date: Sat, 27 Oct 2018 05:55:45 +0000
 > 
 >  A bunch of things:
 >  - You are getting this because your linux distribution defaults to
 >    enabling FORTIFY in the compiler configuration, most likely.
 >    This is fine but very problematic when combined with choosing to 
 > keep
 >    warnings regarding FORTIFY CFLAGS configuration. It's weird that 
 > they
 >    haven't noticed this because it would have more effects, but maybe
 >    they don't want to edit their glibc headers.
 
 I am not sure that Arch guys enable FORTIFY by default.
 
 configure:888: echo cc -E  1>&5; cc -E  conftest.c >/dev/null 
 2>conftest.out
 cc -E
 In file included from /usr/include/assert.h:35,
                   from configure:883:
 /usr/include/features.h:381:4: warning: #warning _FORTIFY_SOURCE 
 requires compiling with optimization (-O) [-Wcpp]
   #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
      ^~~~~~~
 
 I have nor error neither warning if I type the following line in my 
 term:
 $ echo '#include<assert.h>' | cc -E -
 
 But I get the #warnging by running:
 $ echo '#include<assert.h>' | CWRAPPERS_CONFIG_DIR=<long_path> 
 <another_long_path>/cc-wrapper -E -
 
 >  - It's probably fine to patch this. It would be better to do the
 >    non-generated file but I can't generate it easily so I can see why 
 > you
 >    did it that way.
 
 Instead of checking cc -E, configure could check cpp. The cpp-wrapper 
 works fine without enabling FORTIFY. But now, I don't know how to do 
 that.