pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/53594: [x11/py-sip] Fix sip Makefile generation for Qt5

The following reply was made to PR pkg/53594; it has been noted by GNATS.

From: David Holland <>
Subject: Re: pkg/53594: [x11/py-sip] Fix sip Makefile generation for Qt5
Date: Mon, 24 Sep 2018 17:45:41 +0000

 On Tue, Sep 11, 2018 at 03:45:01PM +0000, wrote:
  > However, the test implemented by sip does this only for Linux, which
  > is a bug, as all platforms supported by pkgsrc use the same Qt5
  > library names (and windows + darwin are already handled
  > specifically by sip).
  > I suggest the attached patch.
  > I did not submit it upstream, I prefer that my fix is confirmed first.
 Seems reasonable to me and nothing seems to have exploded since it was
 committed, so I think you should go ahead and send it upstream...
 David A. Holland

Home | Main Index | Thread Index | Old Index