pkg/53614: x11/libXft has inconsistent freetype2 dependency

[mike.volokhov%gmail.com@localhost]

>Number:         53614
>Category:       pkg
>Synopsis:       x11/libXft has inconsistent freetype2 dependency
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 17 22:05:00 +0000 2018
>Originator:     Mike Volokhov
>Release:        pkgsrc-2018Q2
>Organization:
>Environment:
Darwin wakizashi.local 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64

>Description:
On macOS X 10.13 with latest XQuartz 2.7.11 installed when building package x11/libXft the configure stage can't be passed due to ancient freetype2 library.


>How-To-Repeat:
pkgsrc$ cd x11/libXft && make configure
=> Bootstrap dependency digest>=20010302: found digest-20160304
WARNING: [license.mk] Every package should define a LICENSE.
===> Skipping vulnerability checks.
WARNING: No /opt/pkg/pkgdb/pkg-vulnerabilities file found.
WARNING: To fix run: `/opt/pkg/sbin/pkg_admin -K /opt/pkg/pkgdb fetch-pkg-vulnerabilities'.
=> Checksum SHA1 OK for libXft-2.3.2.tar.bz2
=> Checksum RMD160 OK for libXft-2.3.2.tar.bz2
=> Checksum SHA512 OK for libXft-2.3.2.tar.bz2
===> Installing dependencies for libXft-2.3.2nb2
=> Tool dependency libtool-base>=2.4.2nb9: found libtool-base-2.4.6nb1
=> Tool dependency pkgconf-[0-9]*: found pkgconf-1.4.1nb1
=> Tool dependency checkperms>=1.1: found checkperms-1.12
=> Build dependency x11-links>=1.12: found x11-links-1.12
=> Build dependency cwrappers>=20150314: found cwrappers-20180325
=> Full dependency zlib>=1.2.3: found zlib-1.2.11
=> Full dependency fontconfig>=2.13.0: found fontconfig-2.13.0nb1
=> Full dependency freetype2>=2.4.11: found freetype2-2.9
===> Overriding tools for libXft-2.3.2nb2
===> Extracting for libXft-2.3.2nb2
===> Patching for libXft-2.3.2nb2
===> Creating toolchain wrappers for libXft-2.3.2nb2
===> Configuring for libXft-2.3.2nb2
=> Modifying GNU configure scripts to avoid --recheck
=> Replacing config-guess with pkgsrc versions
=> Replacing config-sub with pkgsrc versions
=> Replacing install-sh with pkgsrc version
=> Checking for portability problems in extracted files
... (some lines passed) ...
checking for XRENDER... yes
checking for FREETYPE... yes
checking for FONTCONFIG... configure: error: Package requirements (fontconfig >= 2.5.92) were not met:

Package dependency requirement 'freetype2 >= 21.0.15' could not be satisfied.
Package 'freetype2' has version '18.6.12', required version is '>= 21.0.15'

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables FONTCONFIG_CFLAGS
and FONTCONFIG_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

*** Error code 1

libXft$ ls -l work/.buildlink/lib/libfreetype.*
lrwxr-xr-x  1 mishka  staff  32 Sep 18 00:55 work/.buildlink/lib/libfreetype.6.dylib -> /opt/X11/lib/libfreetype.6.dylib
lrwxr-xr-x  1 mishka  staff  30 Sep 18 00:55 work/.buildlink/lib/libfreetype.dylib -> /opt/X11/lib/libfreetype.dylib
>Fix:
Providing explicit version dependency forces pkgsrc to use own freetype library which fixes the issue:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/x11/libXft/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile	12 Mar 2018 11:15:53 -0000	1.19
+++ Makefile	17 Sep 2018 21:59:03 -0000
@@ -20,6 +20,7 @@
 .include "../../devel/zlib/buildlink3.mk"
 BUILDLINK_API_DEPENDS.fontconfig+=	fontconfig>=2.6
 .include "../../fonts/fontconfig/buildlink3.mk"
+BUILDLINK_API_DEPENDS.freetype2+=	freetype2>=2.8.1
 .include "../../graphics/freetype2/buildlink3.mk"
 .include "../../x11/libXrender/buildlink3.mk"
 .include "../../x11/libX11/buildlink3.mk"


Cheers,
Mishka