pkg/53596: x11/tigervnc needs to build_depends x11/xtrans

[toddpw%gmail.com@localhost]

>Number:         53596
>Category:       pkg
>Synopsis:       x11/tigervnc needs to build_depends x11/xtrans
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 12 08:10:00 +0000 2018
>Originator:     Todd Whitesel
>Release:        pkgsrc-2018Q2
>Organization:
self
>Environment:
NetBSD uni.toddpw.net 7.1 NetBSD 7.1 (GENERIC.201703111743Z) i386
>Description:
x11/tigervnc has a build dependency on x11/xtrans that is not declared, thus it is vulnerable to build failures.
>How-To-Repeat:
Try to build x11/tigervnc without x11/xtrans having been installed first. It will fail during configure with an error about a missing macro that starts with XTRANS_*.
>Fix:
Workaround: manually install x11/xtrans, then clean x11/tigervnc and make install again.

Fix: add the following to x11/tigervnc/Makefile:

BUILD_DEPENDS+= xtrans-[0-9]*:../../x11/xtrans