pkg/53427: pkgsrc-2018Q2 editors/emacs has inconsistent version

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         53427
>Category:       pkg
>Synopsis:       pkgsrc-2018Q2 editors/emacs has inconsistent version
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 06 21:00:00 +0000 2018
>Originator:     Izumi Tsutsui
>Release:        NetBSD 8.0_RC2 + pkgsrc-2018Q2
>Organization:
>Environment:
System: NetBSD mirage 8.0_RC2 NetBSD 8.0_RC2 (GENERIC) #0: Mon Jun 25 13:01:26 UTC 2018 mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
On pkgsrc-2018Q2 pkgsrc/editors/emacs build fails:

---
 :

=> Full dependency emacs-[0-9]*: NOT found
=> Verifying package-install for ../../editors/emacs
WARNING: [license.mk] Every package should define a LICENSE.
===> Installing dependencies for emacs-25.0.50
=> Build dependency cwrappers>=20150314: found cwrappers-20180325
=> Full dependency emacs26>=26: NOT found
=> Verifying package-install for ../../editors/emacs-snapshot
=> Bootstrap dependency digest>=20010302: found digest-20160304
=> Checksum SHA1 OK for emacs-snapshot_2015071614+bd8b5ac77250d9fe0634d58a30a3bf6d2497725a.orig.tar.xz
=> Checksum RMD160 OK for emacs-snapshot_2015071614+bd8b5ac77250d9fe0634d58a30a3bf6d2497725a.orig.tar.xz
=> Checksum SHA512 OK for emacs-snapshot_2015071614+bd8b5ac77250d9fe0634d58a30a3bf6d2497725a.orig.tar.xz
===> Invoking ``package-install'' after barrier for emacs25-25.0.50.2015071614nb23
===> Extracting for emacs25-25.0.50.2015071614nb23
tar: Global extended headers posix ustar archive. Extracting as plain files. Following files might be in the wrong directory or have wrong attributes.
cp /usr/pkgsrc/editors/emacs-snapshot/../../editors/emacs23/files/site-init.el /s/obj.x86_64/pkgsrc/editors/emacs-snapshot/work.x86_64/emacs-snapshot-2015071614+bd8b5ac77250d9fe0634d58a30a3bf6d2497725a/lisp
cp: /usr/pkgsrc/editors/emacs-snapshot/../../editors/emacs23/files/site-init.el: No such file or directory
*** Error code 1

Stop.
make[3]: stopped in /usr/pkgsrc/editors/emacs-snapshot
*** Error code 1

Stop.
make[2]: stopped in /usr/pkgsrc/editors/emacs-snapshot
*** Error code 1

Stop.
make[1]: stopped in /usr/pkgsrc/editors/emacs
*** Error code 1

---

>How-To-Repeat:
cd pkgsrc/editors/emacs && make package

>Fix:
pkgsrc/editors/emacs26 has been imported and now
pkgsrc/mk/defaults/mk.conf has the following line
EMACS_TYPE?=    emacs26
so a snapshot version in emacs/Makefile.common should also be adjusted?

Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/editors/emacs/Makefile.common,v
retrieving revision 1.42
diff -u -p -r1.42 Makefile.common
--- Makefile.common	29 Sep 2017 12:40:27 -0000	1.42
+++ Makefile.common	6 Jul 2018 19:48:30 -0000
@@ -38,7 +38,7 @@ PKG_FAIL_REASON+=	"EMACS_TYPE is xemacs.
 # (Set these to avoid crashing out below.)
 EMACS_PKGDIR=		../../editors/xemacs
 EMACS_PACKAGE=		xemacs
-.elif ${MY_EMACS_TYPE} == "emacs26"
+.elif ${MY_EMACS_TYPE} == "emacs27"
 EMACS_PKGDIR=		../../editors/emacs-snapshot
 EMACS_PACKAGE=		${EMACS_BASE_TYPE}
 .elif !empty(MY_EMACS_TYPE:M*nox)