Re: pkg/53396: xfwm4 crashes

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR pkg/53396; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/53396: xfwm4 crashes
Date: Tue, 26 Jun 2018 08:48:13 +0200

 Obvious bug, sn_startup_sequence_get_last_active_time takes two long pointer
 arguments, but xfc4-wm passes pointers to may-be-different types.
 
 The patch below should fix it.
 
 Martin
 
 
 --- src/startup_notification.c.orig	2015-05-18 14:09:19.000000000 +0200
 +++ src/startup_notification.c	2018-06-26 08:44:51.580042779 +0200
 @@ -128,6 +128,7 @@ sn_collect_timed_out_foreach (void *elem
      SnStartupSequence *sequence;
      time_t tv_sec;
      suseconds_t tv_usec;
 +    long l_sec, l_usec;
      double elapsed;
  
      g_return_if_fail (data != NULL);
 @@ -135,7 +136,8 @@ sn_collect_timed_out_foreach (void *elem
  
      sequence = element;
      ctod = (CollectTimedOutData *) data;
 -    sn_startup_sequence_get_last_active_time (sequence, &tv_sec, &tv_usec);
 +    sn_startup_sequence_get_last_active_time (sequence, &l_sec, &l_usec);
 +    tv_sec = l_sec; tv_usec = l_sec;
  
      elapsed =
          ((((double) ctod->now.tv_sec - tv_sec) * G_USEC_PER_SEC +