pkg/53381: audio/pulseaudio: build is broken in FreeBSD 11.1-RELEASE

[santhosh.raju%gmail.com@localhost]

>Number:         53381
>Category:       pkg
>Synopsis:       audio/pulseaudio: build is broken in FreeBSD 11.1-RELEASE
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 18 04:00:00 +0000 2018
>Originator:     Santhosh Raju
>Release:        pkgsrc-current
>Organization:
>Environment:
FreeBSD fox.trouble.is 11.1-RELEASE-p10 FreeBSD 11.1-RELEASE-p10 #0: Tue May  8 05:21:56 UTC 2018     root%amd64-builder.daemonology.net@localhost:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
pulseaudio fails to build via pkgsrc when run in FreeBSD 11.1-RELEASE. It fails with a message regarding undefined references to various structs.

Partial build output:

gmake[3]: Entering directory '/usr/pkgsrc/audio/pulseaudio/work/pulseaudio-11.1/src'
  CCLD     libprotocol-cli.la
  CCLD     module-cli.la
  CCLD     module-simple-protocol-tcp.la
  CCLD     module-device-manager.la
  CCLD     module-device-restore.la
  CCLD     module-stream-restore.la
  CCLD     module-oss.la
  CC       modules/raop/libraop_la-raop-client.lo
modules/raop/raop-client.c:666:12: warning: cast from 'const uint8_t *' (aka 'const unsigned char *') to 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4
      [-Wcast-align]
    data = (uint32_t *) (packet + sizeof(udp_timing_header));
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
modules/raop/raop-client.c:685:24: error: variable has incomplete type 'struct sockaddr_in'
    struct sockaddr_in sa4;
                       ^
modules/raop/raop-client.c:685:12: note: forward declaration of 'struct sockaddr_in'
    struct sockaddr_in sa4;

...

Makefile:625: recipe for target 'all' failed
gmake: *** [all] Error 2
*** Error code 2

Stop.
>How-To-Repeat:
1. Get current pkgsrc via CVS 
2. Prepare and bootstrap pkgsrc in FreeBSD 11.1-RELEASE
3. cd audio/pulseaudio && bmake
4. After sometime the build fails with the error mentioned in the "Full description"
>Fix:
Added the missing network headers for FreeBSD 11.1.

Steps to fix

1. Apply the following patch in audio/pulseaudio 

--- src/modules/raop/raop-client.h.orig 2018-06-17 16:45:13.878136000 +0000
+++ src/modules/raop/raop-client.h
@@ -26,6 +26,11 @@
 #include <pulsecore/memchunk.h>
 #include <pulsecore/rtpoll.h>

+#if defined (__FreeBSD__)
+#include <sys/socket.h>
+#include <netinet/in.h>
+#endif
+
 typedef enum pa_raop_protocol {
     PA_RAOP_PROTOCOL_TCP,
     PA_RAOP_PROTOCOL_UDP